Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NVIDIA/OpenShell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.10
Choose a base ref
...
head repository: NVIDIA/OpenShell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.11
Choose a head ref
  • 13 commits
  • 51 files changed
  • 5 contributors

Commits on Mar 18, 2026

  1. Configuration menu
    Copy the full SHA
    dcd9912 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d071b8 View commit details
    Browse the repository at this point in the history
  3. fix(ci): check author_association before API calls in vouch gate (#442)

    The vouch-check workflow was closing PRs from NVIDIA org members because
    the GITHUB_TOKEN lacks read:org scope, causing orgs.checkMembershipForUser
    to return 404 for non-public members. The catch block silently swallowed
    these as expected 'not found' responses.
    
    Add an author_association check from the webhook payload as the primary
    bypass. GitHub sets this field server-side (MEMBER, OWNER, COLLABORATOR)
    regardless of membership visibility, with no extra token permissions
    needed. The existing API calls are kept as fallbacks.
    
    Fixes the false positive that closed #430.
    
    Co-authored-by: John Myers <johntmyers@users.noreply.github.com>
    johntmyers and johntmyers authored Mar 18, 2026
    Configuration menu
    Copy the full SHA
    240d0ee View commit details
    Browse the repository at this point in the history
  4. fix(ci): fetch author_association via REST API instead of webhook pay…

    …load (#444)
    
    The webhook payload field context.payload.pull_request.author_association
    is unreliable under pull_request_target events — it was absent or not
    populated, causing the previous fix (#442) to still fail.
    
    Switch to fetching author_association via pulls.get REST API, which only
    needs pull-requests permission (already granted) and reliably returns
    MEMBER for org members regardless of membership visibility.
    
    Also removes the redundant orgs.checkMembershipForUser and
    repos.checkCollaborator fallbacks, which suffered from the same
    GITHUB_TOKEN permission limitation that started this bug.
    
    Co-authored-by: John Myers <johntmyers@users.noreply.github.com>
    johntmyers and johntmyers authored Mar 18, 2026
    Configuration menu
    Copy the full SHA
    85a3d83 View commit details
    Browse the repository at this point in the history
  5. fix(ci): pass wheel filenames as job output instead of re-downloading (

    …#418)
    
    The trigger-wheel-publish job was downloading the wheel artifact onto a
    persistent self-hosted runner just to glob the filenames. Since
    download-artifact does not clean the destination directory, stale .whl
    files from every previous run accumulated in release/ and were all sent
    to GitLab as WHEEL_FILENAMES.
    
    Confirmed on the runner: /home/ubuntu/actions-runner/_work/OpenShell/
    OpenShell/release/ contained 120+ wheels spanning versions 0.0.5
    through 0.0.10.
    
    Fix: capture wheel filenames as a job output in build-python-wheels and
    pass them directly to trigger-wheel-publish. The trigger job no longer
    downloads the artifact at all — it only needs the filenames to construct
    GitHub release asset URLs for GitLab/Kitmaker.
    pimlock authored Mar 18, 2026
    Configuration menu
    Copy the full SHA
    73e1913 View commit details
    Browse the repository at this point in the history
  6. fix(ci): use ORG_READ_TOKEN for org membership check in vouch gate (#445

    )
    
    The GITHUB_TOKEN cannot determine org membership — it lacks read:org
    scope and this is not configurable via the permissions block. Both
    author_association and orgs.checkMembershipForUser return NONE/404 for
    org members (even public ones) when called with the repo-scoped token.
    
    Use an ORG_READ_TOKEN secret (fine-grained PAT with read:org) when
    available, falling back to GITHUB_TOKEN. Also restores the
    checkCollaborator fallback since the PAT can resolve that too.
    
    Setup required: create a fine-grained PAT with Organization > Members >
    Read permission, then add it as a repo secret named ORG_READ_TOKEN.
    
    Co-authored-by: John Myers <johntmyers@users.noreply.github.com>
    johntmyers and johntmyers authored Mar 18, 2026
    Configuration menu
    Copy the full SHA
    82cb8d2 View commit details
    Browse the repository at this point in the history
  7. fix(ci): split vouch gate into two steps with separate tokens (#446)

    The ORG_READ_TOKEN (read:org PAT) was being used for all API calls,
    including closing PRs and posting comments, which it lacks permissions
    for. Split into two steps:
    
    1. Org membership check — uses ORG_READ_TOKEN exclusively
    2. VOUCHED.td check + close — uses default GITHUB_TOKEN (has repo write)
    
    Step 2 is skipped entirely if step 1 confirms org membership.
    
    Co-authored-by: John Myers <johntmyers@users.noreply.github.com>
    johntmyers and johntmyers authored Mar 18, 2026
    Configuration menu
    Copy the full SHA
    e26732b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5565a8b View commit details
    Browse the repository at this point in the history
  9. fix(ci): use env context instead of secrets in step-level if condition (

    #452)
    
    The secrets context is not available in step-level if expressions in
    GitHub Actions — only in with and env blocks. This caused the workflow
    file to be invalid, failing every run with:
    
      Unrecognized named-value: 'secrets'
    
    Fix by exporting the secret to a job-level env var and checking that
    in the step condition instead.
    
    Co-authored-by: John Myers <johntmyers@users.noreply.github.com>
    johntmyers and johntmyers authored Mar 18, 2026
    Configuration menu
    Copy the full SHA
    3566e55 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1a706f3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e45d415 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a912848 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2026

  1. Configuration menu
    Copy the full SHA
    4878b9b View commit details
    Browse the repository at this point in the history
Loading