test(e2e): migrate Bedrock Runtime compatible Anthropic scenario#5356
Merged
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a Bedrock Runtime compatible Anthropic end-to-end Vitest suite: rate-limit detection, fake HTTP/2 Bedrock mock, multi-agent (openclaw/hermes) flows, leak-scanning, per-agent artifact uploads, CI job wiring, and workflow-boundary validators/tests. ChangesBedrock Runtime Compatible Anthropic E2E Test Suite
Sequence DiagramsequenceDiagram
participant CI as CI Job
participant TestHarness as Vitest Runner
participant CLI as Source CLI (on host)
participant Adapter as NemoClaw Adapter
participant FakeBedrock as Fake Bedrock HTTP/2
CI->>TestHarness: start bedrock-runtime-compatible-anthropic-vitest (matrix agent)
TestHarness->>CLI: run onboarding (redacted capture)
CLI->>Adapter: register / authenticate (NEMOCLAW_AGENT)
Adapter->>FakeBedrock: Converse / ConverseStream requests (Authorization, model)
FakeBedrock-->>Adapter: mocked responses (JSON/event-stream)
TestHarness->>FakeBedrock: collect logs and request counts
TestHarness->>CI: upload per-agent artifacts, write scenario-result.json
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt |
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt |
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27436476645
|
Contributor
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27437283117
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27437915415
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27437988514
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27438453812
|
Collaborator
Author
|
Addressing the latest PR Advisor pass:
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27438963009
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27442255653
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27442493415
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/e2e-scenarios/free-standing-jobs.env`:
- Around line 1-5: Remove the SPDX header comment lines at the top of the env
file so the file is data-only: delete the two lines beginning with "#
SPDX-FileCopyrightText" and "# SPDX-License-Identifier" and leave the existing
environment variables (allowed_jobs, free_standing_scenarios_csv,
free_standing_scenario_jobs_csv) unchanged; if SPDX metadata is required, move
it out of this .env into a separate metadata file or ensure any generator strips
comments before validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9be99e01-b272-4867-8c1a-6c3aad4f0321
📒 Files selected for processing (7)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/live/bedrock-runtime-compatible-anthropic-rate-limit.tstest/e2e-scenario/live/bedrock-runtime-compatible-anthropic.test.tstest/e2e-scenario/support-tests/bedrock-runtime-compatible-anthropic-rate-limit.test.tstest/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tstools/e2e-scenarios/free-standing-jobs.envtools/e2e-scenarios/workflow-boundary.mts
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27443294581
|
…ntime-compatible-anthropic
…ntime-compatible-anthropic # Conflicts: # test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts # tools/e2e-scenarios/workflow-boundary.mts
…ntime-compatible-anthropic # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml # test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts # tools/e2e-scenarios/workflow-boundary.mts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Bedrock Runtime compatible Anthropic E2E from the legacy bash surface into a focused live Vitest test while preserving the fake Bedrock endpoint, source CLI onboarding, OpenShell route, agent runtime, and leak-scan boundaries.
Related Issue
Refs #5098 (Phase 5: migrate
test-bedrock-runtime-compatible-anthropic.sh)Changes
test/e2e-scenario/live/bedrock-runtime-compatible-anthropic.test.tscovering the fake Bedrock Runtime endpoint,/etc/hostsmapping, source CLI onboarding, OpenShell route, OpenClaw/Hermes runtime probes, adapter log breadcrumbs, and leak scan.bedrock-runtime-compatible-anthropic-vitestto the manual E2E Vitest workflow with an OpenClaw/Hermes matrix and artifact upload.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Tests
Chores