test(onboard): split vLLM selection suite by cv · Pull Request #5011 · NVIDIA/NemoClaw

cv · 2026-06-09T03:05:43Z

Summary

Split the vLLM provider-selection coverage out of the oversized test/onboard-selection.test.ts suite into a focused test/onboard-selection-vllm.test.ts file. This preserves the existing coverage while giving CI another schedulable test file for the slow onboard-selection group.

Changes

Added test/onboard-selection-vllm.test.ts for running-vLLM detection, validation backout, managed vLLM platform menu, and install-vLLM env-var coverage.
Removed the moved vLLM cases from test/onboard-selection.test.ts.
Ratcheted ci/test-file-size-budget.json for the reduced test/onboard-selection.test.ts line count.

Type of Change

Code change (feature, bug fix, or refactor)
Code change with doc updates
Doc only (prose changes, no code sample modifications)
Doc only (includes code sample changes)

Verification

npx prek run --all-files passes
npm test passes
Tests added or updated for new or changed behavior
No secrets, API keys, or credentials committed
Docs updated for user-facing behavior changes
npm run docs builds without warnings (doc changes only)
Doc pages follow the style guide (doc changes only)
New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

Tests
- Reorganized and expanded test coverage for vLLM provider selection functionality with comprehensive test scenarios across multiple conditions.

coderabbitai · 2026-06-09T03:05:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2c6ee38a-d399-4309-8092-01abe8ccacb3

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7e11a and 6dfe363.

📒 Files selected for processing (3)

ci/test-file-size-budget.json
test/onboard-selection-vllm.test.ts
test/onboard-selection.test.ts

💤 Files with no reviewable changes (1)

test/onboard-selection.test.ts

📝 Walkthrough

Walkthrough

This PR consolidates vLLM provider-selection test coverage into a dedicated test file with expanded test scenarios. A running vLLM detection test is moved from the main onboard suite into test/onboard-selection-vllm.test.ts, accompanied by five new regression and edge-case tests. The original test file's line budget is adjusted to reflect the 601-line removal.

Changes

vLLM Provider Selection Test Consolidation

Layer / File(s)	Summary
vLLM test suite framework and scenarios `test/onboard-selection-vllm.test.ts`	New test file with imports, setup constants, and six test scenarios: (1) running vLLM detection without rerun requirement, (2) validation backout preventing max_model_len application, (3) non-interactive rejection of `NEMOCLAW_PROVIDER=vllm`, (4) platform-specific menu entries for DGX Spark/Station only, (5) regression for `#3765`—explicit `install-vllm` request with unavailable profile returns precise error, and (6) regression for `#3765`—install-vllm override when running server is detected.
Old test removal and budget adjustment `test/onboard-selection.test.ts`, `ci/test-file-size-budget.json`	Removed 601-line "offers detected running vLLM without requiring a rerun" test case from onboard-selection.test.ts and lowered its legacyMaxLines budget from 7757 to 7156.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

NVIDIA/NemoClaw#4905: Both PRs modify ci/test-file-size-budget.json by adjusting per-file legacyMaxLines thresholds that govern test-file oversize detection.

Poem

🐰 A bunny hops through test refactors fine,
Moving vLLM checks to their own design—
Six scenarios dance in subprocess bliss,
Budget shrinks right, no line-count miss! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the primary change: splitting vLLM selection test suite from the main test file into a dedicated file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/split-onboard-selection-vllm

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-09T03:06:37Z

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

None. No E2E is recommended because this PR changes only test files and a CI test-size budget. The diff does not modify runtime/user-flow code for installer/onboarding, credentials, sandbox lifecycle, network policy, inference routing, deployment, or assistant behavior.

Optional E2E

None.

New E2E recommendations

None.

github-actions · 2026-06-09T03:06:38Z

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required scenario E2E

None. Changes are limited to non-scenario test files and a CI test file-size budget; no files under test/e2e-scenario/, scenario workflows, scenario metadata, expected-state contracts, suite definitions, or scenario runtime code were changed.

Optional scenario E2E

None.

Relevant changed files

None.

github-actions · 2026-06-09T03:09:01Z

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas
Top item: No actionable findings

Consider writing more tests for

**Runtime validation** — Run or identify the existing test-file-size budget validation for `test/onboard-selection.test.ts` at the new 7156-line legacy ceiling and `test/onboard-selection-vllm.test.ts` under the default 1500-line ceiling.. Static review confirms the moved tests remain included by Vitest and the budget was ratcheted consistently. Runtime validation is still useful because the change affects test scheduling and the test-file-size guardrail configuration.
**Runtime validation** — Run or identify targeted Vitest coverage for `test/onboard-selection-vllm.test.ts` to confirm the moved vLLM subprocess integration cases are discovered as a separate schedulable test file.. Static review confirms the moved tests remain included by Vitest and the budget was ratcheted consistently. Runtime validation is still useful because the change affects test scheduling and the test-file-size guardrail configuration.
**Acceptance clause:** `npx prek run --all-files` passes — add test evidence or identify existing coverage. This is a PR-provided verification claim and was not executed during this read-only review.
**Acceptance clause:** `npm test` passes — add test evidence or identify existing coverage. This is a PR-provided verification claim and was not executed during this read-only review.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

test(onboard): split vllm selection suite

6dfe363

cv self-assigned this Jun 9, 2026

cv merged commit ab983f2 into main Jun 9, 2026
44 checks passed

cv deleted the codex/split-onboard-selection-vllm branch June 9, 2026 03:12

coderabbitai Bot mentioned this pull request Jun 9, 2026

feat(inference): add interactive managed-vLLM model picker #5038

Merged

12 tasks

cv added the v0.0.62 Release target label Jun 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(onboard): split vLLM selection suite#5011

test(onboard): split vLLM selection suite#5011
cv merged 1 commit into
mainfrom
codex/split-onboard-selection-vllm

cv commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Jun 9, 2026

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Uh oh!

github-actions Bot commented Jun 9, 2026

E2E Scenario Advisor

Required scenario E2E

Optional scenario E2E

Relevant changed files

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cv commented Jun 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of Change

Verification

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Jun 9, 2026

E2E Advisor Recommendation

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Uh oh!

github-actions Bot commented Jun 9, 2026

E2E Scenario Advisor Recommendation

E2E Scenario Advisor

Required scenario E2E

Optional scenario E2E

Relevant changed files

Uh oh!

github-actions Bot commented Jun 9, 2026

PR Review Advisor

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cv commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading