Skip to content

test(cli): split onboard debug suite#4995

Merged
cv merged 1 commit into
mainfrom
codex/split-onboard-debug-tests
Jun 8, 2026
Merged

test(cli): split onboard debug suite#4995
cv merged 1 commit into
mainfrom
codex/split-onboard-debug-tests

Conversation

@cv

@cv cv commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Split the oversized test/cli/onboard-debug.test.ts subprocess suite into focused debug and onboard compatibility suites, and move the lone start regression into dispatch basics. This preserves the existing coverage while giving CI smaller test files to distribute across shards.

Changes

  • Added test/cli/debug-command.test.ts for nemoclaw debug help, quick diagnostics, sandbox selection, and stale-default coverage.
  • Added test/cli/onboard-compatibility.test.ts for onboard/setup/setup-spark/deploy parsing and compatibility coverage.
  • Moved the nemoclaw start no-API-key regression into test/cli/dispatch-basics.test.ts.
  • Removed the combined test/cli/onboard-debug.test.ts suite.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

@cv cv self-assigned this Jun 8, 2026
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cv, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7806ffe5-38d8-4118-a836-512ac2fdcd1f

📥 Commits

Reviewing files that changed from the base of the PR and between ef6b905 and 62a4099.

📒 Files selected for processing (4)
  • test/cli/debug-command.test.ts
  • test/cli/dispatch-basics.test.ts
  • test/cli/onboard-compatibility.test.ts
  • test/cli/onboard-debug.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/split-onboard-debug-tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No E2E is recommended because this PR changes only CLI test files. The diff appears to reorganize and expand unit/integration test coverage for existing CLI behavior, with no runtime code or CI workflow changes that could affect real assistant user flows.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required scenario E2E

  • None. Only CLI unit/integration test files outside test/e2e-scenario/ changed; no scenario E2E runtime, metadata, workflow, suite script, or onboarding/install helper implementation was modified.

Optional scenario E2E

  • None.

Relevant changed files

  • None.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas
Top item: No actionable findings

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv cv merged commit 7896de7 into main Jun 8, 2026
40 checks passed
@cv cv deleted the codex/split-onboard-debug-tests branch June 8, 2026 23:24
@wscurran wscurran added the chore Build, CI, dependency, or tooling maintenance label Jun 8, 2026
@cv cv added the v0.0.62 Release target label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cv cv

Labels

chore Build, CI, dependency, or tooling maintenance v0.0.62 Release target

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cv @wscurran