Skip to content

chore(github): tighten bug report intake#4954

Merged
cv merged 1 commit into
mainfrom
chore/issue-template-intake
Jun 9, 2026
Merged

chore(github): tighten bug report intake#4954
cv merged 1 commit into
mainfrom
chore/issue-template-intake

Conversation

@sandl99

@sandl99 sandl99 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR tightens NemoClaw bug report intake so maintainers get enough context to triage issues. Bug reports now require debug output and logs; agent diagnostics are encouraged but optional.

Bug reports now require:

  • Description
  • Reproduction Steps
  • Environment
  • Debug Output
  • Logs
  • Checklist confirmation that the bug is reproducible and not a duplicate

Feature request and documentation issue templates are unchanged.

Changes

  • Add optional agent-first troubleshooting guidance and an optional Agent Diagnostic field to bug reports.
  • Make Debug Output and Logs required in bug reports.
  • Add contact links for Discussions and troubleshooting so questions are routed away from issues.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Passing verification:

  • ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "ok #{f}" }' .github/ISSUE_TEMPLATE/bug_report.yml .github/ISSUE_TEMPLATE/feature_request.yml .github/ISSUE_TEMPLATE/doc_issue.yml .github/ISSUE_TEMPLATE/config.yml
  • npx prek run --files .github/ISSUE_TEMPLATE/bug_report.yml .github/ISSUE_TEMPLATE/feature_request.yml .github/ISSUE_TEMPLATE/doc_issue.yml .github/ISSUE_TEMPLATE/config.yml

Full npx prek run --all-files was attempted but still fails in unrelated existing CLI tests. No runtime code or tests are changed by this PR.


Signed-off-by: San Dang san1201.bkhn@gmail.com

Signed-off-by: San Dang <san1201.bkhn@gmail.com>
@sandl99 sandl99 self-assigned this Jun 8, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

GitHub issue templates are updated to encourage agent-first diagnostics. The bug report template now requires reporters to run an agent and submit diagnostic output before filing issues. Contact links redirect questions to Discussions and troubleshooting help to documentation.

Changes

Agent-First Issue Handling

Layer / File(s) Summary
Bug report agent diagnostic collection
.github/ISSUE_TEMPLATE/bug_report.yml
Bug report template replaces initial description with agent-first troubleshooting instructions, adds a required "Agent Diagnostic" textarea with example output, and updates validation requirements for the new diagnostic field and existing Logs field.
Issue triage pre-routing
.github/ISSUE_TEMPLATE/config.yml
Contact links are extended with two entries: one directing questions to GitHub Discussions, and one directing troubleshooting requests to repository documentation before bug filing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#4857: Aligns with earlier PR updates to GitHub issue templates that introduced machine-readable triage labels and NemoClaw maintainer workflow policies for issue classification.

Suggested labels

chore, documentation

Suggested reviewers

  • cv

Poem

🐰 A rabbit hops through templates fine,
Guiding bugs to agents divine,
Questions routed before the report—
Smart troubleshooting first, of course!
Agent wisdom leads the way. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the main change: tightening bug report intake by adding requirements for debug output/logs and agent diagnostics.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/issue-template-intake

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No E2E is recommended because the PR only modifies GitHub issue templates/contact links. These are repository-maintenance changes and cannot affect runtime behavior or real user flows exercised by NemoClaw E2E tests.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required scenario E2E

  • None. Only GitHub issue template configuration changed; this cannot affect scenario E2E behavior.

Optional scenario E2E

  • None.

Relevant changed files

  • None.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 3 worth checking, 0 nice ideas
Since last review: 0 prior items resolved, 0 still apply, 2 new items found

Review findings

🛠️ Needs attention

  • None.

🔎 Worth checking

  • Source-of-truth review needed: GitHub bug report template agent-first guidance: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `bug_report.yml` references agent-first investigation and CONTRIBUTING; `CONTRIBUTING.md` only describes confirmed bugs/reproduction steps in the issue-opening section.
  • Required public log fields need redaction and N/A guidance (.github/ISSUE_TEMPLATE/bug_report.yml:77): The bug report form now requires both debug output and additional logs in a public GitHub issue, but the descriptions do not remind reporters to redact tokens, secrets, credentials, or PII. The required Logs field also asks for information "not covered by the debug output above", which may not exist for valid reports and can push users to paste unnecessary raw logs.
    • Recommendation: Add explicit redaction guidance to the Debug Output and Logs descriptions, and give reporters a truthful required-field path such as "Enter N/A if there are no additional logs" or "Paste the command failure if debug cannot run." Consider keeping additional Logs optional if debug output is already required.
    • Evidence: `debug-output` tells users to run `nemoclaw debug --output ...` and is `required: true` at lines 65-71; `logs` asks for additional logs/stack traces and is `required: true` at lines 76-80, with no redaction or N/A guidance.
  • Agent-first bug intake wording is not backed by CONTRIBUTING (.github/ISSUE_TEMPLATE/bug_report.yml:2): The template says "Your agent should investigate first - see CONTRIBUTING.md" and the markdown says to point a coding agent at the repo before filing, but CONTRIBUTING's issue-opening section currently only requires confirmed bugs/reproduction steps and routes questions/security reports elsewhere. The only AI-agent guidance found in CONTRIBUTING is in the Documentation section, so the template creates a process/source-of-truth mismatch.
    • Recommendation: Either update CONTRIBUTING's "Before You Open an Issue" section to document the agent-first bug-report expectation and what to do when a reporter cannot use an agent, or soften the template language so it presents agent diagnostics as optional helpful context rather than a CONTRIBUTING-backed prerequisite.
    • Evidence: `bug_report.yml` lines 2 and 11 reference agent-first investigation and CONTRIBUTING. `CONTRIBUTING.md` lines 38-46 describe when to open issues without an agent-first requirement, while AI-agent guidance appears later in the Documentation section.

🌱 Nice ideas

  • None.
Consider writing more tests for
  • **Mocked behavioral coverage** — Validate `.github/ISSUE_TEMPLATE/bug_report.yml` parses as a GitHub issue form with required description, reproduction, environment, debug-output, logs, and checklist fields.. No runtime unit tests are necessary for this YAML-only issue-template change, but lightweight schema/link validation would reduce regression risk for the intake form and contact links.
  • **Mocked behavioral coverage** — Validate `agent-diagnostic` remains optional while the intended diagnostic fields remain required.. No runtime unit tests are necessary for this YAML-only issue-template change, but lightweight schema/link validation would reduce regression risk for the intake form and contact links.
  • **Mocked behavioral coverage** — Validate required diagnostic fields include redaction guidance and a safe `N/A` or `cannot run` path.. No runtime unit tests are necessary for this YAML-only issue-template change, but lightweight schema/link validation would reduce regression risk for the intake form and contact links.
  • **Mocked behavioral coverage** — Validate each `.github/ISSUE_TEMPLATE/config.yml` contact link points to the intended existing target, including Discussions, `docs/reference/troubleshooting.mdx`, and `SECURITY.md`.. No runtime unit tests are necessary for this YAML-only issue-template change, but lightweight schema/link validation would reduce regression risk for the intake form and contact links.
  • **GitHub bug report template agent-first guidance** — A lightweight repository check or review checklist could verify that issue-template links and process claims are reflected in the referenced documentation.. `bug_report.yml` references agent-first investigation and CONTRIBUTING; `CONTRIBUTING.md` only describes confirmed bugs/reproduction steps in the issue-opening section.
Since last review details

Current findings:

  • Source-of-truth review needed: GitHub bug report template agent-first guidance: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `bug_report.yml` references agent-first investigation and CONTRIBUTING; `CONTRIBUTING.md` only describes confirmed bugs/reproduction steps in the issue-opening section.
  • Required public log fields need redaction and N/A guidance (.github/ISSUE_TEMPLATE/bug_report.yml:77): The bug report form now requires both debug output and additional logs in a public GitHub issue, but the descriptions do not remind reporters to redact tokens, secrets, credentials, or PII. The required Logs field also asks for information "not covered by the debug output above", which may not exist for valid reports and can push users to paste unnecessary raw logs.
    • Recommendation: Add explicit redaction guidance to the Debug Output and Logs descriptions, and give reporters a truthful required-field path such as "Enter N/A if there are no additional logs" or "Paste the command failure if debug cannot run." Consider keeping additional Logs optional if debug output is already required.
    • Evidence: `debug-output` tells users to run `nemoclaw debug --output ...` and is `required: true` at lines 65-71; `logs` asks for additional logs/stack traces and is `required: true` at lines 76-80, with no redaction or N/A guidance.
  • Agent-first bug intake wording is not backed by CONTRIBUTING (.github/ISSUE_TEMPLATE/bug_report.yml:2): The template says "Your agent should investigate first - see CONTRIBUTING.md" and the markdown says to point a coding agent at the repo before filing, but CONTRIBUTING's issue-opening section currently only requires confirmed bugs/reproduction steps and routes questions/security reports elsewhere. The only AI-agent guidance found in CONTRIBUTING is in the Documentation section, so the template creates a process/source-of-truth mismatch.
    • Recommendation: Either update CONTRIBUTING's "Before You Open an Issue" section to document the agent-first bug-report expectation and what to do when a reporter cannot use an agent, or soften the template language so it presents agent diagnostics as optional helpful context rather than a CONTRIBUTING-backed prerequisite.
    • Evidence: `bug_report.yml` lines 2 and 11 reference agent-first investigation and CONTRIBUTING. `CONTRIBUTING.md` lines 38-46 describe when to open issues without an agent-first requirement, while AI-agent guidance appears later in the Documentation section.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@wscurran

wscurran commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@sandl99 for Bug Reports, can you also make sure the template:

  1. Sets Issue Type to Bug (don't add bug label)
  2. Adds "needs: triage" label - this puts it in triage queue

@wscurran wscurran added area: project-management Taxonomy, triage, workflow, roadmap, or project process chore Build, CI, dependency, or tooling maintenance labels Jun 8, 2026
@cv cv added the v0.0.62 Release target label Jun 9, 2026
@cv cv merged commit 1dfdd0c into main Jun 9, 2026
40 checks passed
@cv cv deleted the chore/issue-template-intake branch June 9, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: project-management Taxonomy, triage, workflow, roadmap, or project process chore Build, CI, dependency, or tooling maintenance v0.0.62 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants