docs: recommend nemoclaw exec for one-off commands#4117
Conversation
Signed-off-by: Glenn-Agent <glenn_agent@163.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughUpdated CLI selection docs: OpenShell bypass examples now show upload/download + raw exec with HOME verification; Connect section now recommends ChangesCLI Selection Guide
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this detailed PR about recommending Related open issues: |
prekshivyas
left a comment
There was a problem hiding this comment.
Thanks — the content and direction are right (correctly implements #4087: recommend nemoclaw <name> exec, reframe openshell sandbox exec as the lower-level path). Holding approval on two things:
1. Merge conflict — needs a rebase + reformat (blocking). The branch is CONFLICTING. Since this PR was opened, docs/reference/cli-selection-guide.mdx was reformatted on main:
- code fences changed from
```console(with$prompts) to```bash(no$prompt) - prose was rewrapped to one sentence per line (semantic line breaks)
Please rebase on main and re-apply the change in the current house style:
- use a
```bashfence with no$prompt for thenemoclaw my-assistant exec -- cat /tmp/gateway.logexample - split the added explanatory sentences one-per-line to match the surrounding text
2. Wording (non-blocking). I traced nemoclaw <name> exec through the code — it's a thin passthrough: src/commands/sandbox/exec.ts → execSandbox() (src/lib/actions/sandbox/exec.ts) just runs openshell sandbox exec --name <name> ... -- <cmd>, forwarding only --workdir/--tty/--timeout. No env injection or provisioning in the wrapper. So both nemoclaw <name> exec and openshell sandbox exec hit the same OpenShell exec endpoint in the same provisioned sandbox → identical sandbox user, HOME=/sandbox, agent config, inference routing, and policy state (baked in at provision time, not applied per-exec). The real differentiators are NemoClaw registry name resolution and CLI ergonomics, not the execution environment. The current phrasing slightly implies openshell sandbox exec would miss the provisioned config, which isn't the case. Optional tightening:
…use
nemoclaw <name> exec. It resolves the sandbox by its NemoClaw registry name and runs through the standard NemoClaw CLI surface. The command executes as the sandbox user withHOME=/sandboxinside the provisioned sandbox (agent config, inference routing, and policy state are already in place). Useopenshell sandbox execfor the raw OpenShell path — e.g. addressing a sandbox by its gateway name or bypassing the NemoClaw CLI.
Note this framing traces to #4087's Expected Result, so if there's a governing spec the same tweak may belong upstream. Happy to re-approve once the rebase lands.
Resolve cli-selection-guide.mdx conflict: re-apply the nemoclaw exec recommendation in the current bash-fence house style (no $ prompt, sentence-per-line) and tighten the wording so the nemoclaw exec vs openshell sandbox exec distinction reflects registry/UX, not a different execution environment. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
prekshivyas
left a comment
There was a problem hiding this comment.
Approving. Pushed a merge of main into this branch (forward-only, no force-push) that resolves the cli-selection-guide.mdx conflict and re-applies the change in the current house style — ```bash fences, no $ prompt, sentence-per-line — matching the rest of the file after the recent reformat.
While resolving I also tightened the wording so the nemoclaw <name> exec vs openshell sandbox exec distinction is accurate: it's about NemoClaw registry name-resolution and the CLI surface, not a different execution environment. (Both paths run through the same OpenShell exec endpoint in the same provisioned sandbox — nemoclaw <name> exec is a thin passthrough in src/lib/actions/sandbox/exec.ts, so the sandbox user, HOME=/sandbox, agent config, inference routing, and policy state are identical either way.)
Net diff is docs-only, MDX parses (docs-to-skills.py --dry-run), git diff --check clean. Branch is now MERGEABLE. Good for v0.0.58 once checks go green.
Summary
nemoclaw <name> execfor one-off in-sandbox commands in the CLI selection guideopenshell sandbox execis the lower-level bypass pathHOME=/sandbox, and NemoClaw-provisioned config/routing/policy stateFixes #4087
Tests
npm run docspython3 scripts/docs-to-skills.py docs/ .agents/skills/ --prefix nemoclaw-user --doc-platform fern-mdx --dry-rungit diff --checkSigned-off-by: Glenn-Agent glenn_agent@163.com
Summary by CodeRabbit