scripts/nemoclaw-start.sh (1)

48-87: Please run the entrypoint E2Es on this branch before merge.

This hardening sits on the sandbox boot path, and the unit test here only exercises an extracted snippet rather than the full Landlock/non-root/process-lifecycle path. I’d run sandbox-survival-e2e, sandbox-operations-e2e, and cloud-e2e for this change.

As per coding guidelines, scripts/nemoclaw-start.sh: This file is a sandbox entrypoint script. Changes affect every sandbox boot and are invisible to unit tests (Landlock, non-root execution, process lifecycle). and E2E test recommendation: sandbox-survival-e2e, sandbox-operations-e2e, cloud-e2e.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/nemoclaw-start.sh` around lines 48 - 87, The change in
scripts/nemoclaw-start.sh affects sandbox boot behavior (see prepare_start_log
function and its invocation at the bottom) and must be validated with full
entrypoint E2E runs before merging; please run the recommended end-to-end suites
sandbox-survival-e2e, sandbox-operations-e2e, and cloud-e2e against this branch
(exercising Landlock/non-root/process-lifecycle paths) and post the passing
results or any fixes, referencing prepare_start_log and the two calls that
invoke it for root and non-root paths.

test/nemoclaw-start.test.ts (1)

120-151: ⚡ Quick win

Add a regression for the real-directory refusal path.

The new helper also refuses to replace _START_LOG when it is an actual directory, but this suite only locks in the symlink-replacement branch. A small companion case that pre-creates logPath as a directory and asserts a non-zero exit plus an unchanged directory would cover the other security contract introduced here.

🧪 Suggested companion test

+  it("refuses to replace a real directory at the startup log path", () => {
+    const src = fs.readFileSync(START_SCRIPT, "utf-8");
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-start-log-dir-"));
+    const logPath = path.join(tmpDir, "nemoclaw-start.log");
+    fs.mkdirSync(logPath);
+
+    try {
+      const block = earlyStartLogBlock(src).replace(
+        '_START_LOG="/tmp/nemoclaw-start.log"',
+        `_START_LOG=${JSON.stringify(logPath)}`,
+      );
+      const result = spawnSync("bash", ["-c", ["set -euo pipefail", block].join("\n")], {
+        encoding: "utf-8",
+        timeout: 5000,
+      });
+
+      expect(result.status).not.toBe(0);
+      expect(fs.statSync(logPath).isDirectory()).toBe(true);
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true });
+    }
+  });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/nemoclaw-start.test.ts` around lines 120 - 151, Add a companion test to
cover the real-directory refusal path: create a new it block alongside "replaces
a pre-existing startup log symlink..." that pre-creates logPath as a directory
(instead of a symlink), writes trustedPath, builds the script using
earlyStartLogBlock with _START_LOG set to JSON.stringify(logPath), spawns bash
as in the existing test, and assert the process exits non-zero and that the
pre-existing directory at logPath still exists and is unchanged (e.g.,
isDirectory and trustedPath contents unchanged). Ensure you reference
earlyStartLogBlock, logPath and trustedPath when locating the relevant setup and
assertions.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes