chore(ci): remove CodeRabbit E2E recommendations by jyaunches · Pull Request #3723 · NVIDIA/NemoClaw

jyaunches · 2026-05-18T13:36:00Z

Summary

remove CodeRabbit path_instructions that emitted E2E test recommendations
keep the generic nightly-e2e workflow maintenance note for aggregate needs lists
narrow validate-e2e-coverage.test.ts to workflow-internal checks now that Pi E2E advisor owns recommendations

Test

npm test -- test/validate-e2e-coverage.test.ts

Context

E2E recommendation ownership has moved from CodeRabbit path instructions to the Pi-backed E2E advisor workflow.

Summary by CodeRabbit

Tests
- Refocused E2E validation to check nightly workflow internal consistency: verify selective-dispatch guards on nightly jobs and that aggregate jobs list all nightly job dependencies.
Chores
- Updated CodeRabbit guidance for nightly E2E workflows to emphasize rename/removal handling: update aggregate job dependency lists for notify-on-failure, report-to-pr, and scorecard.

coderabbitai · 2026-05-18T13:41:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c57586d7-df75-45eb-a271-c0c6d5174b8c

📥 Commits

Reviewing files that changed from the base of the PR and between fd0fddb and ddd9683.

📒 Files selected for processing (2)

.coderabbit.yaml
test/validate-e2e-coverage.test.ts

✅ Files skipped from review due to trivial changes (1)

.coderabbit.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

test/validate-e2e-coverage.test.ts

📝 Walkthrough

Walkthrough

This PR shortens the .coderabbit.yaml instructions for .github/workflows/nightly-e2e.yaml and refactors test/validate-e2e-coverage.test.ts to validate nightly-e2e.yaml internal consistency: each nightly job’s selective-dispatch if: and aggregate jobs’ needs coverage.

Changes

Nightly E2E Validation Refactoring

Layer / File(s)	Summary
Update validation guidance in CodeRabbit config `.coderabbit.yaml`	`path_instructions` for `.github/workflows/nightly-e2e.yaml` shortened: removed new-job/cross-validation guidance and updated rename/removal instructions to reference aggregate-job `needs` lists (`notify-on-failure`, `report-to-pr`, `scorecard`).
Refactor test to validate workflow consistency `test/validate-e2e-coverage.test.ts`	Test refocused to load `nightly-e2e.yaml` and assert each nightly job has the selective-dispatch `if:` guard and that each aggregate job's `needs` includes all nightly E2E jobs; removed config-parsing helpers and cross-validation tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

NVIDIA/NemoClaw#3426: Modifies nightly-e2e.yaml (auto-dispatch and reporting) which affects nightly job/aggregate needs relationships validated by the updated test.

Suggested labels

enhancement: testing

Suggested reviewers

cv

Poem

🐰 A little hop through config lines,
I trimmed the notes and checked the signs.
Jobs guarded right, aggregates neat—
Tests now count each nightly beat.
Cheers from a rabbit, light and fleet.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore(ci): remove CodeRabbit E2E recommendations' accurately summarizes the main change: removing CodeRabbit path_instructions that emitted E2E test recommendations, as confirmed by both the raw summary and PR objectives.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

test/validate-e2e-coverage.test.ts (1)
32-42: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update comment to include all three aggregate jobs.

The comment on line 35 lists only two infrastructure jobs (notify-on-failure, report-to-pr) but the code on line 40 correctly excludes three jobs including scorecard. Update the comment for consistency.
📝 Proposed fix
 /**
  * Extract all E2E job names from the nightly-e2e.yaml workflow.
  * A job is any top-level key under `jobs:` except infrastructure jobs
- * (`notify-on-failure`, `report-to-pr`).
+ * (`notify-on-failure`, `report-to-pr`, `scorecard`).
  */
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/validate-e2e-coverage.test.ts` around lines 32 - 42, The comment above
getNightlyJobNames is out of sync with the code: update the comment that
currently lists only two infra jobs to include all three
aggregate/infrastructure jobs ("notify-on-failure", "report-to-pr", "scorecard")
so it matches the infra set in the function and clearly documents which
top-level jobs are excluded.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@test/validate-e2e-coverage.test.ts`:
- Around line 32-42: The comment above getNightlyJobNames is out of sync with
the code: update the comment that currently lists only two infra jobs to include
all three aggregate/infrastructure jobs ("notify-on-failure", "report-to-pr",
"scorecard") so it matches the infra set in the function and clearly documents
which top-level jobs are excluded.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ad2b9a85-6f30-42ce-b7c0-4b82559935a0

📥 Commits

Reviewing files that changed from the base of the PR and between 50ad764 and fd0fddb.

📒 Files selected for processing (2)

.coderabbit.yaml
test/validate-e2e-coverage.test.ts

coderabbitai Bot reviewed May 18, 2026

View reviewed changes

wscurran added CI/CD labels May 18, 2026

chore(ci): remove CodeRabbit E2E recommendations

ddd9683

jyaunches force-pushed the chore/remove-coderabbit-e2e-recommendations branch from fd0fddb to ddd9683 Compare May 18, 2026 15:19

jyaunches added the v0.0.46 Release target label May 18, 2026

cv approved these changes May 18, 2026

View reviewed changes

ericksoa merged commit 32ddb1b into NVIDIA:main May 19, 2026
19 checks passed

This was referenced May 19, 2026

test(e2e): cover onboard negative paths #3791

Merged

fix(hermes): avoid rc rewrites after capability drop #3914

Merged

ci(e2e): add channels-add-remove to nightly-e2e workflow #3932

Merged

wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance and removed CI/CD labels Jun 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): remove CodeRabbit E2E recommendations#3723

chore(ci): remove CodeRabbit E2E recommendations#3723
ericksoa merged 1 commit into
NVIDIA:mainfrom
jyaunches:chore/remove-coderabbit-e2e-recommendations

jyaunches commented May 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 18, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jyaunches commented May 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test

Context

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jyaunches commented May 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 18, 2026 •

edited

Loading