Skip to content

test: update OpenShell gateway upgrade stub features#3429

Merged
ericksoa merged 1 commit into
mainfrom
fix/openshell-gateway-upgrade-feature-stub
May 13, 2026
Merged

test: update OpenShell gateway upgrade stub features#3429
ericksoa merged 1 commit into
mainfrom
fix/openshell-gateway-upgrade-feature-stub

Conversation

@ericksoa

@ericksoa ericksoa commented May 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add the OpenShell 0.0.39 credential-rewrite feature markers to the fake macOS openshell stubs used by the gateway upgrade E2E
  • keep the entitlement-repair regression test on the installer path instead of failing at the new feature-string gate

Verification

  • bash -n test/e2e/test-openshell-gateway-upgrade.sh scripts/install-openshell.sh
  • shellcheck test/e2e/test-openshell-gateway-upgrade.sh scripts/install-openshell.sh
  • local reproduction of exercise_macos_vm_driver_entitlement_repair passed: installer exited 0, codesign was called with entitlements, and no OpenShell release reinstall occurred

Notes

Summary by CodeRabbit

  • Tests
    • Updated macOS installer test infrastructure to enhance regression test coverage.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c602cffd-45fd-4714-ad1e-74536c203c02

📥 Commits

Reviewing files that changed from the base of the PR and between 8166365 and 0eddff6.

📒 Files selected for processing (1)
  • test/e2e/test-openshell-gateway-upgrade.sh
📝 Walkthrough

Walkthrough

The e2e upgrade regression script adds identical credential rewrite documentation comments to the generated fake OpenShell binary used in two macOS installer test scenarios: the incomplete OpenShell CLI install regression path and the VM driver entitlement repair regression path.

Changes

macOS Installer Test Documentation

Layer / File(s) Summary
OpenShell fake script documentation
test/e2e/test-openshell-gateway-upgrade.sh		 Two inert comment lines indicating credential rewrite behavior are inserted into the generated openshell fake script in exercise_macos_gateway_installer_regression (lines 145–146) and exercise_macos_vm_driver_entitlement_repair (lines 234–235). The comments do not affect test behavior or exit codes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Two comments hop in, both neat and the same,
Test fixtures now documented—a very small change,
No logic is broken, no output is shifted,
Just words in the scripts, gracefully gifted!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/openshell-gateway-upgrade-feature-stub

Comment @coderabbitai help to get the list of available commands and usage tips.

@ericksoa ericksoa merged commit d18e4e2 into main May 13, 2026
62 of 64 checks passed
This was referenced May 13, 2026
Merged
Merged
Merged
Merged
@wscurran wscurran added the chore Build, CI, dependency, or tooling maintenance label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericksoa @wscurran