Skip to content

fix(onboard): accept --yes flag on oclif onboard command#3066

Merged
cv merged 1 commit into
mainfrom
fix/onboard-cli-yes-flag
May 5, 2026
Merged

fix(onboard): accept --yes flag on oclif onboard command#3066
cv merged 1 commit into
mainfrom
fix/onboard-cli-yes-flag

Conversation

@zyang-dev

@zyang-dev zyang-dev commented May 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

The oclif-migrated nemoclaw onboard command was missing a --yes flag declaration, so any non-interactive install through scripts/install.sh failed with Nonexistent flag: --yes. install.sh has appended --yes to onboard since before the migration to auto-accept the Ollama model-download size prompt; this PR adds the flag to the oclif command and forwards it to the legacy parser, restoring non-interactive installs end-to-end.

Changes

  • src/lib/onboard-cli-commands.ts: add yes boolean flag (with -y short form) to OnboardFlags, buildOnboardFlags(), and the usage string. Forward as --yes in toLegacyOnboardArgs() so the legacy onboard-command.ts parser sets autoYes.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • make docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: zyang-dev 267119621+zyang-dev@users.noreply.github.com

Summary by CodeRabbit

  • New Features
    • Added --yes / -y flag to the onboard CLI to automatically accept Ollama model-download size confirmation during setup.

@zyang-dev
fix(onboard): accept --yes flag on oclif onboard command
aabd0c5 
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fb020f80-ea33-4c3c-ad4a-4c04bd67efa3

📥 Commits

Reviewing files that changed from the base of the PR and between e7e73c1 and aabd0c5.

📒 Files selected for processing (1)
  • src/lib/onboard-cli-commands.ts
📝 Walkthrough

Walkthrough

A new --yes / -y flag is added to the onboard CLI command to automatically accept Ollama model-download size confirmations. The flag is integrated into the type definitions, usage documentation, flag parser, and legacy argument handling.

Changes

Onboard CLI Yes Flag

Layer / File(s) Summary
Type Definition
src/lib/onboard-cli-commands.ts		 OnboardFlags interface gains optional yes?: boolean field.
Usage Documentation
src/lib/onboard-cli-commands.ts		 Onboard usage string is updated to display --yes | -y alongside existing flags.
Flag Parsing
src/lib/onboard-cli-commands.ts		 buildOnboardFlags adds the new yes flag definition with character alias y and auto-accept description.
Legacy Argument Handling
src/lib/onboard-cli-commands.ts		 toLegacyOnboardArgs is extended to emit --yes when the flag is set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A flag so swift, with --yes so spry,
No prompts to pester, no need to deny,
Just tap the y and away we fly,
Auto-accepts bloom as moments pass by! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(onboard): accept --yes flag on oclif onboard command' accurately and specifically describes the main change: adding a --yes flag to the oclif onboard command to fix non-interactive installation failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/onboard-cli-yes-flag

Comment @coderabbitai help to get the list of available commands and usage tips.

@zyang-dev zyang-dev self-assigned this May 5, 2026
@cv cv merged commit 18fe336 into main May 5, 2026
20 checks passed
@hunglp6d hunglp6d mentioned this pull request May 6, 2026
Closed
2 tasks
@Dongni-Yang Dongni-Yang mentioned this pull request May 8, 2026
Merged
14 tasks
@wscurran wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cv cv cv approved these changes

Assignees

@zyang-dev zyang-dev

Labels

bug-fix PR fixes a bug or regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zyang-dev @cv @wscurran