src/nemoclaw.ts (1)

317-324: Run the two recovery-focused E2E lanes before merge.

Since this changes restart/recovery behavior, validate with sandbox-survival-e2e and sandbox-operations-e2e in CI to catch post-respawn integration regressions.

As per coding guidelines: src/nemoclaw.ts E2E test recommendation includes sandbox-survival-e2e and sandbox-operations-e2e.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/nemoclaw.ts` around lines 317 - 324, This change to restart/recovery
behavior in src/nemoclaw.ts (the shell startup/recovery command array that
includes checks for NODE_OPTIONS, curl healthcheck to DASHBOARD_PORT, and temp
log/lock cleanup) requires running the two recovery-focused E2E lanes before
merging: trigger sandbox-survival-e2e and sandbox-operations-e2e for this
PR/branch in CI and attach their green runs to the review; if your CI config
requires it, add those two jobs to the PR pipeline or re-run the workflow that
includes them so their successful results are present prior to merge.

test/nemoclaw-start.test.ts (1)

38-42: ⚡ Quick win

Escape the marker parameter before using it in RegExp constructor.

While the current call sites use safe string literals, the marker parameter should be escaped to prevent issues if it contains regex metacharacters. This is a defensive coding improvement.

🛡️ Proposed fix

 function startScriptHeredoc(src: string, marker: string): string {
-  const match = src.match(new RegExp(`<<'${marker}'\\n([\\s\\S]*?)\\n${marker}`));
+  const escapedMarker = marker.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  const match = src.match(new RegExp(`<<'${escapedMarker}'\\n([\\s\\S]*?)\\n${escapedMarker}`));
   expect(match).toBeTruthy();
   return match![1];
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/nemoclaw-start.test.ts` around lines 38 - 42, The startScriptHeredoc
function builds a RegExp from the marker parameter without escaping it; escape
marker before constructing the RegExp to avoid treating regex metacharacters as
special. Update startScriptHeredoc to create an escapedMarker (e.g. via a small
escapeRegExp helper or marker.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')) and use
that escapedMarker when building the RegExp passed to src.match so the heredoc
boundary is matched literally.