test/onboard.test.ts (1)

289-307: Add a trim/empty-env boundary test for NEMOCLAW_POLICY_PRESETS.

Current coverage validates non-empty override and interactive behavior, but it doesn’t lock the " " / "" case where previous policies should still carry. Adding that case would prevent regressions around env normalization.

Suggested test addition

   describe("shouldCarryPreviousPolicies (`#2675`)", () => {
@@
     it("ignores env var in interactive mode (previous list still wins)", () => {
       expect(
         shouldCarryPreviousPolicies(["npm"], {
           nonInteractive: false,
           envPolicyPresetsRaw: "pypi",
         }),
       ).toBe(true);
     });
+
+    it("treats empty/whitespace env var as not overriding previous policies", () => {
+      expect(
+        shouldCarryPreviousPolicies(["npm"], {
+          nonInteractive: true,
+          envPolicyPresetsRaw: "   ",
+        }),
+      ).toBe(true);
+      expect(
+        shouldCarryPreviousPolicies(["npm"], {
+          nonInteractive: true,
+          envPolicyPresetsRaw: "",
+        }),
+      ).toBe(true);
+    });
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/onboard.test.ts` around lines 289 - 307, Add a test that verifies
shouldCarryPreviousPolicies treats empty or whitespace-only
NEMOCLAW_POLICY_PRESETS as "no override" so previous policies are carried;
update the test suite around describe("shouldCarryPreviousPolicies (`#2675`)") to
include a case (using shouldCarryPreviousPolicies([...], { nonInteractive: true,
envPolicyPresetsRaw: "   " }) and/or envPolicyPresetsRaw: "") that expects true,
referencing the shouldCarryPreviousPolicies function to locate where to add the
assertion.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/lib/onboard.ts (1)

5761-5770: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Honor explicit NEMOCLAW_POLICY_MODE here too.

The carry-forward decision still only looks at NEMOCLAW_POLICY_PRESETS. On non-interactive recreate, explicit modes like skip|none|no can still reuse cached presets via the resume path, and custom|list can bypass the required env-var validation.

💡 Suggested fix

 function shouldCarryPreviousPolicies(
   previousPolicies: string[] | null | undefined,
-  options: { nonInteractive?: boolean; envPolicyPresetsRaw?: string } = {},
+  options: {
+    nonInteractive?: boolean;
+    envPolicyPresetsRaw?: string;
+    policyModeRaw?: string;
+  } = {},
 ): boolean {
   if (!Array.isArray(previousPolicies) || previousPolicies.length === 0) return false;
   const nonInteractive = options.nonInteractive ?? isNonInteractive();
+  const policyMode = (options.policyModeRaw ?? process.env.NEMOCLAW_POLICY_MODE ?? "suggested")
+    .trim()
+    .toLowerCase();
   const envRaw = (
     options.envPolicyPresetsRaw ?? process.env.NEMOCLAW_POLICY_PRESETS ?? ""
   ).trim();
+  if (nonInteractive && ["skip", "none", "no", "custom", "list"].includes(policyMode)) {
+    return false;
+  }
   return !(nonInteractive && envRaw.length > 0);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/onboard.ts` around lines 5761 - 5770, The function
shouldCarryPreviousPolicies currently only checks NEMOCLAW_POLICY_PRESETS;
update shouldCarryPreviousPolicies to also read and consider
NEMOCLAW_POLICY_MODE (e.g., process.env.NEMOCLAW_POLICY_MODE or options if you
add support) when deciding to carry previous policies: if nonInteractive and
either envPolicyPresetsRaw is present OR NEMOCLAW_POLICY_MODE is set to an
explicit mode that implies using presets (or conversely set to skip/none/no to
prevent reuse), return false accordingly; adjust the return logic in
shouldCarryPreviousPolicies to include this additional mode-based guard so
resume paths cannot bypass env-var validation for modes like skip|none|no and
custom|list are handled correctly.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes