fix(e2e): set alternate dashboard port for multi-sandbox test#2124
Conversation
PR #2086 added a port-collision guard in ensureDashboardForward() that throws when a second sandbox tries to claim the same dashboard port. TC-SBX-10 onboards sandbox B without overriding CHAT_UI_URL, hitting the new guard. Use port 18790 for the second sandbox.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test-sandbox-operations.sh file was modified to set the CHAT_UI_URL environment variable inline when invoking the onboard_sandbox function for sandbox B, ensuring the function receives a specific URL during the multi_sandbox_metadata test execution. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
ensureDashboardForward()but the E2E test was not updated to use a differentCHAT_UI_URLfor sandbox BCHAT_UI_URL=http://127.0.0.1:18790when onboarding the second sandboxTest plan
sandbox-operations-e2ejob passes (TC-SBX-10, TC-SBX-11)Fixes regression from #2086.
Summary by CodeRabbit
Note: This release contains no user-facing changes. Updates are limited to internal testing procedures.