src/lib/onboard.ts (1)

2038-2055: Extract this recovery branch out of preflight().

This adds another decision path to a function that is already complexity-suppressed. Moving the SSH-forward cleanup/retry into a small helper would make the port-check loop easier to reason about and test. As per coding guidelines, "Limit cyclomatic complexity to 20 in JavaScript/TypeScript files, with target of 15"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/onboard.ts` around lines 2038 - 2055, The port-orphan recovery logic
inside preflight() (the branch that detects DASHBOARD_PORT held by an "ssh"
process, kills the pid via run(...), sleeps, and re-checks via
checkPortAvailable) should be extracted to a small helper like
recoverOrphanedSshForward(port: number): Promise<boolean>; move the conditional
that checks port === DASHBOARD_PORT && portCheck.process === "ssh" &&
portCheck.pid into that helper, perform run(...) and sleep(1) there, re-run
checkPortAvailable(port) and return true if the port becomes available (false
otherwise), and replace the inline block in preflight() with a single await call
to recoverOrphanedSshForward(port) to keep preflight()’s loop simpler and lower
cyclomatic complexity; keep references to GATEWAY_PORT, DASHBOARD_PORT,
gatewayReuseState, checkPortAvailable, run, and sleep unchanged so callers still
behave the same.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/lib/onboard.ts (1)

2048-2056: ⚠️ Potential issue | 🟠 Major

Don't clean up OpenShell SSH forwards unless the NemoClaw gateway is known gone.

This still terminates a foreign active OpenShell dashboard forward: when gatewayReuseState === "foreign-active", the ssh args will also contain openshell, but the surrounding preflight logic says those conflicts should be surfaced rather than remediated. Please gate the cleanup to states that prove the NemoClaw gateway is missing/stale before calling kill.

💡 Suggested guard

-      if (port === DASHBOARD_PORT && portCheck.process === "ssh" && portCheck.pid) {
+      const canCleanupDashboardForward =
+        gatewayReuseState === "missing" ||
+        gatewayReuseState === "stale" ||
+        gatewayReuseState === "active-unnamed";
+      if (
+        port === DASHBOARD_PORT &&
+        canCleanupDashboardForward &&
+        portCheck.process === "ssh" &&
+        portCheck.pid
+      ) {
         // Use `ps` to get the command line — works on Linux, macOS, and WSL.
         const cmdline = runCapture(
           `ps -p ${portCheck.pid} -o args= 2>/dev/null`,
           { ignoreError: true },
         ).trim();

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/onboard.ts` around lines 2048 - 2056, The cleanup currently kills
processes whose args include "openshell" regardless of gatewayReuseState; change
the condition so the kill is only run when gatewayReuseState indicates the
NemoClaw gateway is actually missing/stale (i.e., not "foreign-active"). In the
block that checks port === DASHBOARD_PORT && portCheck.process === "ssh" &&
portCheck.pid and computes cmdline, add a guard using the gatewayReuseState
variable (e.g., only proceed with console.log and run(`kill ...`) when
gatewayReuseState !== "foreign-active" and/or equals the specific
"missing"/"stale" values your preflight logic uses) so foreign-active openshell
forwards are not terminated.