Skip to content

nightly-e2e: Hermes rebuild test fixture missing Discord agentRender entries #5263

@hunglp6d

Description

@hunglp6d

Bug Report

Description

Problem Statement

The rebuild-hermes and rebuild-hermes-stale-base nightly E2E jobs failed because the test fixture in test/e2e/test-rebuild-hermes.sh has an empty agentRender array ('agentRender': []) in the expected compiled plan for the Discord channel. Commit 80de9f0 migrated NemoClaw to plan-backed channel state where ManifestCompiler.compile() produces agentRender entries for each channel — specifically three Discord entries (discord-hermes-env, discord-hermes-config, discord-hermes-platform) — but the E2E fixture was not updated. After a sandbox rebuild, the compiled plan contains these entries but the test expects an empty list, causing the assertion to fail:

FAIL: compiled plan mismatch after rebuild — agentRender entries differ

Proposed Design

Populate the agentRender array in the test fixture at line 279 of test/e2e/test-rebuild-hermes.sh with the three Discord render entries that ManifestCompiler.compile() produces for the Hermes agent, matching the structure defined in src/lib/messaging/channels/discord/manifest.ts (lines 127–167):

  1. discord-hermes-env (kind: env-lines, target: ~/.hermes/.env) — Discord bot token, guild IDs, allowed users
  2. discord-hermes-config (kind: json-fragment, target: ~/.hermes/config.yaml, path: discord) — mention, channels, threading, reactions
  3. discord-hermes-platform (kind: json-fragment, target: ~/.hermes/config.yaml, path: platforms.discord) — enabled flag

Alternatives Considered

None — the fixture must match compiler output; there is no alternative structure.

Category

test_failure

Reproduction Steps

  1. Check out NemoClaw at commit a3ae21b6eed8399099fd390bd45ad43e78218258
  2. Run the rebuild-hermes or rebuild-hermes-stale-base E2E scenario
  3. Observe that the compiled plan comparison fails on agentRender

Environment

  • OS: GitHub Actions runner (Ubuntu 22.04)
  • Node.js: v22.16+
  • Docker: Docker-in-Docker (GitHub Actions)
  • NemoClaw: main @ a3ae21b
  • Other: Nightly E2E run 27386272836

Debug Output

N/A — CI job logs available at https://github.com/NVIDIA/NemoClaw/actions/runs/27386272836

Logs

FAIL: compiled plan mismatch after rebuild — agentRender entries differ
Expected agentRender to contain 3 Discord render entries, got 0

Checklist

  • I confirmed this bug is reproducible (required)
  • I searched existing issues and this is not a duplicate (required)

Suggested Labels

nightly-e2e, auto-diagnosed, test-failure, hermes, e2e


Suggested Labels (apply manually after triage)

nightly-e2e, auto-diagnosed, test-failure, hermes, e2e


Related PR: #5260

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions