-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(gateway-state): accept Running phase as alive alongside Ready #3138
Copy link
Copy link
Labels
area: cliCommand line interface, flags, terminal UX, or outputCommand line interface, flags, terminal UX, or outputarea: installInstall, setup, prerequisites, or uninstall flowInstall, setup, prerequisites, or uninstall flowarea: onboardingOnboarding FSM, provider setup, sandbox launch, or first-run flowOnboarding FSM, provider setup, sandbox launch, or first-run flowplatform: brevAffects Brev hosted development environmentsAffects Brev hosted development environments
Metadata
Metadata
Assignees
Labels
area: cliCommand line interface, flags, terminal UX, or outputCommand line interface, flags, terminal UX, or outputarea: installInstall, setup, prerequisites, or uninstall flowInstall, setup, prerequisites, or uninstall flowarea: onboardingOnboarding FSM, provider setup, sandbox launch, or first-run flowOnboarding FSM, provider setup, sandbox launch, or first-run flowplatform: brevAffects Brev hosted development environmentsAffects Brev hosted development environments
Type
Fields
Give feedbackNo fields configured for Bug.
Summary
src/lib/gateway-state.ts:isSandboxReady()only recognizes theReadyphase as indicating a live sandbox:On some Brev deployments and during certain sandbox lifecycle transitions, the sandbox reports phase
Runningwhich is functionally equivalent toReady(the agent is live, health checks pass inside the sandbox). The CLI treats this as "not ready" which cascades into:nemoclaw <name> statusreporting the sandbox as downProposed Fix
Update tests in
src/lib/gateway-state.test.ts(or co-located test file) to cover theRunningphase.Context
This is the CLI-side prerequisite for brevdev/nemoclaw-image#10, which replaces the onboard-ui's reinvented health checks with NemoClaw CLI calls.
Originated from #2258 (sub-item #4), which has been closed with work redirected to the nemoclaw-image repo for the Brev-specific fixes.