Description
Repository
Description
Multiple test files set process.env with API key values that closely resemble real credential formats. While these are test values, they follow the exact prefix patterns of real keys (nvapi-, sk-, sk-ant-), making them indistinguishable from real credentials to:
- Secret scanning tools (GitHub secret scanning, GitGuardian, TruffleHog)
- CI/CD log monitors
- Automated security scanners
Affected locations in test/onboard.test.js:
- Line 505:
process.env.NVIDIA_API_KEY = "nvapi-secret-value"
- Line 744:
process.env.OPENAI_API_KEY = "sk-bad"
- Line 816:
process.env.ANTHROPIC_API_KEY = "sk-ant-secret-value"
- Line 898: similar patterns
- Line 963: similar patterns
Impact
- False positive noise: Secret scanners flag these, causing alert fatigue
- Accidental real key insertion: Developers may copy-paste test patterns and accidentally insert real keys
- CI log leakage: If test output includes env vars, these look like real credential exposures
- Compliance: Security auditors flagging realistic-looking keys in source code
Affected Area
- Module(s): Test suite
- File(s): test/onboard.test.js (lines 505, 744, 816, 898, 963)
Fix Direction
Replace all test credential values with clearly-prefixed test markers:
process.env.NVIDIA_API_KEY = "nvapi-test-00000000-0000-0000-0000-000000000000";
process.env.OPENAI_API_KEY = "sk-test-not-real-key-for-testing-only";
process.env.ANTHROPIC_API_KEY = "sk-ant-test-not-real-key-for-testing-only";
Notes
This is hygiene issue, but it reduces secret scanning noise and prevents accidental credential exposure through copy-paste patterns.
Reproduction Steps
Steps to Reproduce
- Run any secret scanner against the repository
- Observe false positives on test credential values
grep -rn "nvapi-\|sk-\|sk-ant-" test/
Expected Behavior
Test credentials should use clearly-fake prefixes that won't trigger secret scanners, e.g.:
nvapi-test-00000000-0000-0000-0000-000000000000
sk-test-not-a-real-key
sk-ant-test-not-a-real-key
Actual Behavior
Test credentials use realistic-looking values that trigger secret scanning tools.
Evidence
// test/onboard.test.js line 505
process.env.NVIDIA_API_KEY = "nvapi-secret-value";
// test/onboard.test.js line 744
process.env.OPENAI_API_KEY = "sk-bad";
Environment
- OS: Any
- NemoClaw Version / Commit: main branch HEAD
- Branch: main
Debug Output
$ grep -rn "nvapi-\|sk-\|sk-ant-" test/
test/onboard.test.js:505:process.env.NVIDIA_API_KEY = "nvapi-secret-value"
test/onboard.test.js:744:process.env.OPENAI_API_KEY = "sk-bad"
test/onboard.test.js:816:process.env.ANTHROPIC_API_KEY = "sk-ant-secret-value"
Logs
Checklist
Description
Repository
Description
Multiple test files set
process.envwith API key values that closely resemble real credential formats. While these are test values, they follow the exact prefix patterns of real keys (nvapi-,sk-,sk-ant-), making them indistinguishable from real credentials to:Affected locations in
test/onboard.test.js:process.env.NVIDIA_API_KEY = "nvapi-secret-value"process.env.OPENAI_API_KEY = "sk-bad"process.env.ANTHROPIC_API_KEY = "sk-ant-secret-value"Impact
Affected Area
Fix Direction
Replace all test credential values with clearly-prefixed test markers:
Notes
This is hygiene issue, but it reduces secret scanning noise and prevents accidental credential exposure through copy-paste patterns.
Reproduction Steps
Steps to Reproduce
grep -rn "nvapi-\|sk-\|sk-ant-" test/Expected Behavior
Test credentials should use clearly-fake prefixes that won't trigger secret scanners, e.g.:
nvapi-test-00000000-0000-0000-0000-000000000000sk-test-not-a-real-keysk-ant-test-not-a-real-keyActual Behavior
Test credentials use realistic-looking values that trigger secret scanning tools.
Evidence
Environment
Debug Output
Logs
Checklist