[MXFP8] Mirror fixes in Mbridge for mxfp8 param gather #4818
Merged
yaox12 merged 1 commit intoMay 19, 2026
Conversation
Signed-off-by: qiyuw <qiyuw@nvidia.com>
kunlunl
reviewed
May 18, 2026
| forward_pre_hook_enabled = len(model[0].remove_forward_pre_hook_handles) > 0 | ||
| if forward_pre_hook_enabled: | ||
| full_cg_captured = FullCudaGraphWrapper.cuda_graph.get("training") is not None | ||
| if forward_pre_hook_enabled or full_cg_captured: |
Contributor
There was a problem hiding this comment.
I remembered the reason that we disabled _copy_main_params_to_param_buffer in the first step is it didn't call the post ag process, so the grad was not zeroed. Does full cg have same problem here?
Contributor
There was a problem hiding this comment.
Please see the reason in this PR: NVIDIA-NeMo/Megatron-Bridge#3076
Contributor
|
/ok to test ef3fd23 |
Contributor
|
cc @Victarry |
yaox12
approved these changes
May 19, 2026
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26072602128 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26076498105 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR is supposed to be dev-only, which mirrors this commit from #4562
Mbridge PR: NVIDIA-NeMo/Megatron-Bridge#3727
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.