Skip to content

[Dev][MoE] Add a new score function to the router#4193

Merged
yaox12 merged 1 commit into
NVIDIA:devfrom
yaox12:xiny/add_new_score_func_dev
Apr 8, 2026
Merged

[Dev][MoE] Add a new score function to the router#4193
yaox12 merged 1 commit into
NVIDIA:devfrom
yaox12:xiny/add_new_score_func_dev

Conversation

@yaox12

@yaox12 yaox12 commented Apr 8, 2026

Copy link
Copy Markdown
Member

What does this PR do ?

  1. Add a new score function sqrtsoftplus to the router.
  2. Change a little to how we handle the precision in the router
  • TLDR: In topk_routing_with_score_function, we only convert to BF16 before returning (not in the middle).
  • Basic rules:
    • Logits are converted to fp32 at the beginning for score functions.
    • All the intermediate calculations are in fp32.
    • The final probs are casted to the same dtype as the logits.
    • In compute_routing_scores_for_aux_loss, we always use FP32.

Main PR: #3673

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12 yaox12 requested review from a team as code owners April 8, 2026 07:19
@copy-pr-bot

copy-pr-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12 yaox12 enabled auto-merge April 8, 2026 07:25
@yaox12

yaox12 commented Apr 8, 2026

Copy link
Copy Markdown
Member Author

/ok to test dfabf03

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 8, 2026
@yaox12 yaox12 added this pull request to the merge queue Apr 8, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24126367211

Merged via the queue into NVIDIA:dev with commit 7fec528 Apr 8, 2026
61 of 63 checks passed
@yaox12 yaox12 deleted the xiny/add_new_score_func_dev branch April 8, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants