Skip to content

Remove CUDADriverAPIDynamicLoader#4226

Merged
wujingyue merged 1 commit intomainfrom
wjy/writevalue
Apr 10, 2025
Merged

Remove CUDADriverAPIDynamicLoader#4226
wujingyue merged 1 commit intomainfrom
wjy/writevalue

Conversation

@wujingyue
Copy link
Collaborator

@wujingyue wujingyue commented Apr 10, 2025

It's no longer needed after #4197

@wujingyue
Remove CUDADriverAPIDynamicLoader
f956bed 
It's no longer needed after #4197
@wujingyue
Copy link
Collaborator Author

wujingyue commented Apr 10, 2025

!test

@wujingyue wujingyue requested a review from zasdfgbnm April 10, 2025 05:23
@github-actions
Copy link

github-actions bot commented Apr 10, 2025

Description

  • Removed unused CUDADriverAPIDynamicLoader class

Changes walkthrough 📝

Relevant files
Enhancement
driver_api.cpp
Remove CUDADriverAPIDynamicLoader                                               

csrc/driver_api.cpp

  • Removed CUDADriverAPIDynamicLoader namespace and class
  • Simplified file by removing unnecessary code
    		• +0/-11   

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Possible Issue

    The removal of CUDADriverAPIDynamicLoader might lead to unresolved symbols at runtime if any CUDA driver API functions are not properly linked.

    // How does the magic work?
//
// Let's take driver API cuGetErrorName as an example. Because all nvFuser's
// code are in the nvfuser namespace, when we define nvfuser::cuGetErrorName,

    @wujingyue wujingyue merged commit 802f042 into main Apr 10, 2025
    31 of 32 checks passed
    @wujingyue wujingyue deleted the wjy/writevalue branch April 10, 2025 05:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @zasdfgbnm zasdfgbnm zasdfgbnm approved these changes

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @wujingyue @zasdfgbnm