Use 2024.1 API for secure desktop changes#309
Conversation
|
Thanks for your work on this! I'll review and test it and attempt to get it merged this weekend! |
This comment was marked as abuse.
This comment was marked as abuse.
|
Marking as draft as this PR has been postponed until 2024.1 |
|
Note the PR as it currently stands is incompatible with 2023.X, further modifications are needed if NVDARemote wishes to release an add-on version which supports both 2023.X and 2024.X |
|
Marking as ready for review as nvaccess/nvda#14488 has been merged |
|
Given the imminent release of NVDA 2024.1, are there any updates on the merging of this PR? |
|
@codeofdusk, thanks for the reminder about the NVDA 2024.1 release. We're juggling quite a few priorities, and not everyone has the bandwidth to track specific release schedules closely. I'll check the status of this PR and provide an update. We value your diligence and understanding as we balance various project demands. |
|
Closing in favour of #330 |
nvaccess/nvda#14488 proposes a change of API, which will break how NVDA remote interacts with a secure desktop. This PR has been created to support this new API. NVDARemote compatibility with other API breaking changes have not been tested, as this is the main change we are concerned with integrating into NVDARemote.
There may be other API changes proposed for 2023.1 that affect NVDARemote.
A smoke test of NVDA remote is required for this including the following:
SecureDesktopNVDAObject, replace with extension point nvaccess/nvda#14488 instance (with patched add-on) controlling/controlled by an 2022.4 instance (with released add-on).SecureDesktopNVDAObject, replace with extension point nvaccess/nvda#14488 instance (with patched add-on) controlling/controlled by a RemoveSecureDesktopNVDAObject, replace with extension point nvaccess/nvda#14488 instance (with patched add-on).Testing the following functionality:
A packaged copy of the patched addon can be downloaded here to test with:
remote-2.5.zip
A try build of the proposed NVDA changes can be downloaded here to test with: https://ci.appveyor.com/api/buildjobs/gq8kprbkssea2lbp/artifacts/output%2Fnvda_snapshot_try-remove-SecureDesktopNVDAObject-27444%2C15dbc382.exe