Change mask color for nan/inf values to light grey for contour plots#180
Conversation
with min rather than min+1 to not draw entire background as min
sjanzou
left a comment
There was a problem hiding this comment.
On MacOS 14.6.1, the test file parametrics are displayed nicely:
However, on the "Heat map" results tab, the default color map is jet and shows the NaN values as (same for all colormap selections)
The confusing issue is that on the "Heat map" page, the NaN color is the same as the zero color
with data comparison
Regardless, your pull request is a great improvement!
| // assume RebuildMask has been called | ||
| wxColor bgc(m_cmap->ColourForValue(m_zMin)); | ||
| //wxColor bgc(m_cmap->ColourForValue(m_zMin)); | ||
| wxColor bgc(*wxLIGHT_GREY); |
There was a problem hiding this comment.
Maybe this should be a defined value like CONTOUR_BG or COUNTOUR_NAN_COLOR for future maintenance - what do you think?
This is happening in plcolourmap.cpp line 162. Essentially, the wxDVDMapCtrl is passing NaNs to the ColourForValue() function, where the wxPLContourPlot class is masking nonfinite values and essentially skipping them in the ColourForValue process, just keeping the gray background color. An easy fix would be to make the Non-finite color for the heatmaps the light grey instead of black, if you think that makes sense.
|
tab nonfinite values
|
From latest commit. Also check implementation of wxCONTOUR_BG definition in plcolourmap.h (included in both heat map generation files). |
-Rather than drawing nonfinite results as the minimum color in contour plots, draw them as light grey
-Start from the minimum value for contour layer plotting rather than min value + 1; previously, contour made min color the background then counted from the next layer
-Light grey preset is now background color before any layers are drawn
-Useful in parametrics with Nan or inf values in outputs, such as payback period or internal rate of return