fix gen length issue that broke REopt sizing call#952
Merged
Conversation
10 tasks
cpaulgilman
approved these changes
Dec 12, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Tested with hourly data / analysis_period = 25 and 15-minute data / analysis_period = 30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly account for the fact that PVWatts only generates one year of data when calling the REopt API. Fixes NatLabRockies/SAM#1290
Rigorous testing would include multiple timesteps and analysis periods for both PVWatts-Battery and Detailed PV-Battery