update community solar npv to use annual benefits, not cumulative#929
Merged
Conversation
cpaulgilman
approved these changes
Nov 10, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. See NatLabRockies/SAM#1242.
sjanzou
reviewed
Nov 10, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Please note that best practice is to regenerate the affected json files for future comparisons per email sent 11/10/2022.
| "community_solar_upfront_revenue" : 0, | ||
| "subscriber1_npv" : 7954940.5535759041, | ||
| "subscriber2_npv" : 3158303.7010947196, | ||
| "subscriber1_npv" : 923830.933, |
Collaborator
There was a problem hiding this comment.
Please note that any dependent outputs in the json file will now not be valid if compared. See email sent 11/10/2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to annual net benefits to better match typical formulation for NPV. Expected decrease in subscriber NPV in tests.
Fixes #928