PV angle var table checks#885
Merged
Merged
Conversation
monthly_tilt constraints
check values in array during precheck?)
10 tasks
sjanzou
requested changes
Oct 6, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, can you please add the "?=0" to the titl_eq_lat values?
sjanzou
approved these changes
Oct 13, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and all tests passing on Windows and Github Actions.
Please merge in changes to cmod_pvsamv1 in latest commit that fixes the broken SAM_api project. Line 846 was missing a comma in the vartable.
Collaborator
|
@mjprilliman, FYI - I committed the updated SAM_api generated files to the sam-1087-fix branch of SAM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fix requirements for tilt angle definitions in var table
-Added requirements for terrain slope inputs to check constraints in precheck
-ssc errors for monthly tilt angle arrays that cannot (?) be checked in precheck
-Closes NatLabRockies/SAM#1087
-See SAM pull request as well