add capability for AC connected battery to charge from fuel cell#880
Merged
Conversation
mjprilliman
approved these changes
Oct 3, 2022
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good.
Consider adding autonomy autographs for this Fuel Cell configuration:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fuel cell output power to AC outage calculations to fix NatLabRockies/SAM#1130
File with Will's test instructions (see issue for details):
sam_1130_test_case.zip
Haven't done DC because there are no SAM configurations with batteries that are DC connected to PV with fuel cells.