Updated loss factor calculations for lifetime, subhourly options;#878
Conversation
pvsamv1 setup to test
|
@mjprilliman. since 1164 has conflicts that need to be resolved, I am not sure how to test this for single year models. Can you please provide a few ssc tests for the 7 different lifetime array options for maybe pvsamv1 and solar water heating or empirical trough so we can see results for both lifetime and single year models? |
Added tests for lifetime and non-lifetime application of losses. Also fixed merge conflicts in 1164. |
sjanzou
left a comment
There was a problem hiding this comment.
Please review Geothermal Single Owner case with SAM pull request 1164.
Electricity Net Generation does not reflect the annual losses posted in the widget.
with results
Test file
geothermal_annual_loss.zip
This should be fixed in most recent commits |
Working well in last commit |
sjanzou
left a comment
There was a problem hiding this comment.
Tested geothermal and empirical trough all modes with test file.
emp_trough_subhourly.zip
Seems good for lock down! Great work!
-See matching PR in SAM NatLabRockies/SAM#1164
-Update calculations in loss factor setup for 7 different lifetime array options (single value, annual, monthly, weekly, daily, hourly, subhourly)
-Test in pvsamv1 for now
TODO:
-Apply to other relevant cmods
Test file included in NatLabRockies/SAM#1164