Ssc 865 improve dispatch#877
Merged
Merged
Conversation
added 6 commits
August 22, 2022 19:40
…prove_dispatch
…d disabling clip charge code for stand alone battery
dguittet
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865 and #840 - see those issues for test cases.
Results from test file in #792 were mixed, one case increased in revenue, the four others decreased between 8% and 13%. All cases had more revenue than code prior to 792, see attached for details (column K is this PR):
sam_745_dispatch_comparison.xlsx
Future work in #866 and #569 should lead to increases in revenue for those cases.