Conversation
Collaborator
Author
|
Tests added and updated for pvwattsv8, summary document attached along with reference. |
brtietz
requested changes
Sep 20, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Looks like this fixes the problem- having the inverter efficiency as a time series output is very helpful. Just need to update some tolerances to the mac tests pass as well.
All tests pass locally on Windows and MacOS
brtietz
approved these changes
Sep 21, 2022
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.