Add advanced bifacial PV and ground irradiance modeling#871
Merged
Conversation
mjprilliman
reviewed
Sep 26, 2022
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
I haven't come across any issues.
| throw exec_error(cmName, "invalid pv module model type"); | ||
| } | ||
|
|
||
| // TODO: reimplement, but fix issues that this causes with some tests |
Contributor
Author
There was a problem hiding this comment.
The commented out code I initially added should of course not cause an issue, but it does. I'm just pointing it out here, but I wasn't able to quickly troubleshoot why.
| {SSC_INPUT, SSC_NUMBER, "subarray2_dcwiring_loss", "Sub-array 2 DC wiring loss", "%", "", "Losses", "?", "MIN=0,MAX=100", "" }, | ||
| {SSC_INPUT, SSC_NUMBER, "subarray2_tracking_loss", "Sub-array 2 DC tracking error loss", "%", "", "Losses", "?", "MIN=0,MAX=100", "" }, | ||
| {SSC_INPUT, SSC_NUMBER, "subarray2_nameplate_loss", "Sub-array 2 DC nameplate loss", "%", "", "Losses", "?", "MIN=-5,MAX=100", "" }, | ||
| {SSC_INPUT, SSC_NUMBER, "subarray2_electrical_mismatch", "Sub-array 2 electrical mismatch loss", "%", "", "Losses", "?", "MIN=0,MAX=100", "" }, |
Collaborator
There was a problem hiding this comment.
Should these be specifically 'subarrayn_bifacial_electrical_mismatch'?
Contributor
Author
There was a problem hiding this comment.
They could, but aren't to keep the variable name short. I added 'bifacial' to the labels.
mjprilliman
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds: