Cycle and mspt cmod updates#861
Merged
Merged
Conversation
bypasses all the layers for design parameters not subject to optimization routines
tested against base case
tested against base case
tested against base case
tested against base case
bug introduced recently when P_high_limit moved to constructor, so it was never on develop repo
this impacts the field optimization call
added the reserve to remove multiple reallocations
rearrange mspt cmod
Adding ACC design scaling
fix outputs when design is 1 cooling unit
move evap_dt to cycle class member data to remove identical hardcoded magic numbers in cooler and cycle methods
same issues as indirect cycle class
- Removed duplicate code - Moved minimum normalized temperature to a member variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a few bugs in the steam Rankine power cycle models:
The net result of these changes increases the annual energy of the default molten salt power tower technology model in SAM by about 5%. Other technology defaults have a smaller response - see the test results file in the SAM repo.
This pull request also begins to transition the molten salt power tower user interface to define calculated variables through a callback to the power tower compute module. While a few input pages still use the equations window, all MSPT cmod inputs are either direct user inputs from the UI or translated from widget values (e.g. HTF code translated from 0-based array to fluid code corresponding to drop-down labels)