Skip to content

Cycle and mspt cmod updates#861

Merged
tyneises merged 65 commits into
developfrom
cycle_and_mspt_cmod_updates
Aug 16, 2022
Merged

Cycle and mspt cmod updates#861
tyneises merged 65 commits into
developfrom
cycle_and_mspt_cmod_updates

Conversation

@tyneises

@tyneises tyneises commented Aug 15, 2022

Copy link
Copy Markdown
Collaborator

This pull request fixes a few bugs in the steam Rankine power cycle models:

  • Improves calculation of normalized cycle performance from nondimensional tables
  • Removes artificial lower limit on air-cooled condenser pressure
  • Insures that cycle model and air cooler model assume same design point approach temperatures and calls performance model during cycle design method to verify it generates the design point performance and calculate design point fan and pumping power.

The net result of these changes increases the annual energy of the default molten salt power tower technology model in SAM by about 5%. Other technology defaults have a smaller response - see the test results file in the SAM repo.

This pull request also begins to transition the molten salt power tower user interface to define calculated variables through a callback to the power tower compute module. While a few input pages still use the equations window, all MSPT cmod inputs are either direct user inputs from the UI or translated from widget values (e.g. HTF code translated from 0-based array to fluid code corresponding to drop-down labels)

tyneises and others added 30 commits April 25, 2022 13:26
bypasses all the layers for design parameters not subject to optimization routines
bug introduced recently when P_high_limit moved to constructor, so it was never on develop repo
this impacts the field optimization call
added the reserve to remove multiple reallocations
qualand and others added 23 commits June 10, 2022 15:32
fix outputs when design is 1 cooling unit
move evap_dt to cycle class member data to remove identical hardcoded magic numbers in cooler and cycle methods
same issues as indirect cycle class
- Removed duplicate code
- Moved minimum normalized temperature to a member variable
@tyneises tyneises closed this Aug 15, 2022
@tyneises tyneises reopened this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants