Ssc 599 negative cleared capacity#826
Merged
Merged
Conversation
added 5 commits
May 26, 2022 11:42
…s and sum these into the appropriate place in the cash flow. update the test npvs now that we're not double counting revenue
sjanzou
requested changes
May 31, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Great that the SO and merchant plant results are aligning!
Two issues:
- "capacity_factor_sales" is missing from results in Summary tab in SAM, e.g.
- The default results have changed significantly for SAM - please review ssc_599_negative_cleared_capacity branch of SAM and pull request NatLabRockies/SAM#1058
…tive_cleared_capacity
Collaborator
|
Looks good to me aside from the missing |
…tive_cleared_capacity
Collaborator
Author
sjanzou
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Improve handling of cleared capacity throughout merchant plant code, and some bugfixes for the battery time series prices.
The result is that given the same price series for one year, merchant plant and single owner now (once again?) produce the same financial results. Test file here:
aligned price series.zip
Differences in the "all markets" case are worth some debate, but I worried they'll be late for the patch, so I created another issue here: #825