Fix standalone battery capacity factor, add sales capacity factor#820
Merged
Conversation
factor for standalone, gen battery
brtietz
approved these changes
May 18, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Code makes sense, pending Paul's approval of names. Does there need to be an associated SAM PR to add this to the stand-alone battery metrics table?
| { SSC_INPUT, SSC_NUMBER, "run_resiliency_calcs", "Enable resilence calculations for every timestep", "0/1", "0=DisableCalcs,1=EnableCalcs", "Load", "?=0", "", "" }, | ||
| { SSC_INOUT, SSC_NUMBER, "capacity_factor", "Capacity factor", "%", "", "System Output", "?=0", "", "" }, | ||
| { SSC_INOUT, SSC_NUMBER, "capacity_factor", "Capacity factor", "%", "", "System Output", "", "", "" }, | ||
| { SSC_OUTPUT, SSC_NUMBER, "capacity_factor_sales", "Capacity factor based on energy sales", "%", "", "System Output", "", "", "" }, |
Collaborator
There was a problem hiding this comment.
I think our preferred language here is "Capacity factor based on energy to grid" - "energy sales" is sort of internal code lingo.
13 tasks
cpaulgilman
approved these changes
May 20, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good after my label changes per email discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Remove 0 initialization for capacity factor to allow for capacity factor calculation
-Add capacity factor based on energy sales within gen for standalone battery, generic battery (should it be there for all technologies?)
-Fixes #819