Improve module ceofficient generator error reporting#802
Merged
Conversation
sjanzou
approved these changes
Apr 21, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and much more information!
| "max_slope(0.015 * Voc 0.98 * Voc) > 0" }; | ||
| if (err < 0) | ||
| throw general_error("could not solve, check inputs"); | ||
| throw general_error("Could not solve, sanity check failed (" + std::to_string(err) + "): " + err_values[x] ); |
Collaborator
There was a problem hiding this comment.
Looks good, and fits into our "standard" error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the generic error message for cmod_6parsolve "could not solve, check inputs" with more informative error messages based on the sanity check performed on the inputs here: https://github.com/NREL/ssc/blob/5ec04426cdfc4f83c397feb7c1ef66753ab9a70e/shared/6par_solve.h#L307.
Addresses NatLabRockies/SAM#17
To test, create a Detailed PV / No Financial case, choose the "CEC Performance Model with User Entered Specifications" option on the Module page, try different unrealistic values for the input parameters, and click Calculate and plot.
Alternatively, build SDKtool and try modifying parameter values in the attached LK script for SDKtool:
coeffgen6par_sdktool.zip