Ssc 745 improve fom dispatch#792
Merged
Merged
Conversation
added 6 commits
April 1, 2022 13:08
… hours of discharge
…ove_fom_dispatch
added 2 commits
April 7, 2022 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional variables to the FOM dispatch code such that the price to charge and discharge reflects the capacity of the battery, rather than just the maximum price in the forecast.
File for testing and comparison to HOPP:
autodispatch_improvements_hopp.zip
Fixes #745
A note on save_as_JSON_test_run: the NPV in the current defaults goes up by ~2%, so it's not clear to me why this one is going down by <1%.