Skip to content

Sam 978 annual vars to lifetime#791

Merged
brtietz merged 4 commits into
patchfrom
sam_978_annual_vars_to_lifetime
Apr 11, 2022
Merged

Sam 978 annual vars to lifetime#791
brtietz merged 4 commits into
patchfrom
sam_978_annual_vars_to_lifetime

Conversation

@brtietz

@brtietz brtietz commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

Extend variables in pvsamv1 and cmod_battery to lifetime variables, as per request in NatLabRockies/SAM#978 This fits the scope of a patch change.

Larger changes may occur in NatLabRockies/SAM#926

@brtietz brtietz added enhancement pv photovoltaic, pvsam, pvwatts battery labels Apr 4, 2022
@brtietz brtietz added this to the 2021.12.02 Patch 2 milestone Apr 4, 2022
@brtietz brtietz requested a review from cpaulgilman April 4, 2022 21:45
@cpaulgilman

Copy link
Copy Markdown
Collaborator

This looks good! I checked Detailed PV and Detailed PV - Battery configurations for BTM and FOM systems at hourly and 15-minute time steps.

One issue is the Data Tables category says "Three Hour Data" instead of "Lifetime Hourly Data" or "Lifetime 15 Minute Data."

image

@brtietz

brtietz commented Apr 8, 2022

Copy link
Copy Markdown
Collaborator Author

Hmm, that's new, and I suspect is caused by this recent change in the SAM repository: https://github.com/NREL/SAM/blob/c8ef80585337bebce4753f6d2f654ba3226b4b1b/src/results.cpp#L159 I get the same issue on the patch branch of ssc.

@mjprilliman - can you walk us through why that changed from row_length == 2920? Putting a multiple of 8760 through that code results in an fmod of 0. Would it work to just move that later in the if/else chain?

@mjprilliman

Copy link
Copy Markdown
Collaborator

Hmm, that's new, and I suspect is caused by this recent change in the SAM repository: https://github.com/NREL/SAM/blob/c8ef80585337bebce4753f6d2f654ba3226b4b1b/src/results.cpp#L159 I get the same issue on the patch branch of ssc.

@mjprilliman - can you walk us through why that changed from row_length == 2920? Putting a multiple of 8760 through that code results in an fmod of 0. Would it work to just move that later in the if/else chain?

That was a remnant of the JPD file generation work that probably should have not been included in the merge or at the very least tested more thoroughly. I think the best course of action is for me to revert that.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Hmm, that's new, and I suspect is caused by this recent change in the SAM repository: https://github.com/NREL/SAM/blob/c8ef80585337bebce4753f6d2f654ba3226b4b1b/src/results.cpp#L159 I get the same issue on the patch branch of ssc.
@mjprilliman - can you walk us through why that changed from row_length == 2920? Putting a multiple of 8760 through that code results in an fmod of 0. Would it work to just move that later in the if/else chain?

That was a remnant of the JPD file generation work that probably should have not been included in the merge or at the very least tested more thoroughly. I think the best course of action is for me to revert that.

Resolved in NatLabRockies/SAM#1001

@brtietz brtietz merged commit 41eaf8a into patch Apr 11, 2022
@brtietz brtietz deleted the sam_978_annual_vars_to_lifetime branch April 29, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants