Sam 978 annual vars to lifetime#791
Conversation
… to allow for running the tests more easily
|
Hmm, that's new, and I suspect is caused by this recent change in the SAM repository: https://github.com/NREL/SAM/blob/c8ef80585337bebce4753f6d2f654ba3226b4b1b/src/results.cpp#L159 I get the same issue on the patch branch of ssc. @mjprilliman - can you walk us through why that changed from row_length == 2920? Putting a multiple of 8760 through that code results in an fmod of 0. Would it work to just move that later in the if/else chain? |
That was a remnant of the JPD file generation work that probably should have not been included in the merge or at the very least tested more thoroughly. I think the best course of action is for me to revert that. |
Resolved in NatLabRockies/SAM#1001 |

Extend variables in pvsamv1 and cmod_battery to lifetime variables, as per request in NatLabRockies/SAM#978 This fits the scope of a patch change.
Larger changes may occur in NatLabRockies/SAM#926