Fix cf energy sales#750
Conversation
cpaulgilman
left a comment
There was a problem hiding this comment.
@brtietz I've got related changes in the om_var_labels branch (https://github.com/NREL/ssc/tree/om_var_labels). I can merge fix_cf_energy_sales into om_var_labels and get these changes into patch via that route. OK?
| @@ -606,8 +606,6 @@ static var_info _cm_vtab_communitysolar[] = { | |||
| /* PPA revenue not applicable to community solar, may need to be restored later | |||
| { SSC_OUTPUT, SSC_ARRAY, "cf_ppa_price", "PPA price", "cents/kWh", "", "Cash Flow Revenues", "*", "LENGTH_EQUAL=cf_length", "" }, | |||
| { SSC_OUTPUT, SSC_ARRAY, "cf_energy_value", "PPA revenue net", "$", "", "Cash Flow Revenues", "*", "LENGTH_EQUAL=cf_length", "" }, | |||
There was a problem hiding this comment.
I am confused based on the email chain... are we keeping "net" here or does that go away when @cpaulgilman merges his changes?
There was a problem hiding this comment.
We can remove net, but this is in commented out code, so it won't change anything. Should I remove net or just remove the whole block?
There was a problem hiding this comment.
Good point... we should be consistent and removing commented code - only keep if necessary or informative. Would you say this is clarifying or just a historic artifact? (Useful for debugging in the future?)
sjanzou
left a comment
There was a problem hiding this comment.
Comment removal at your discretion!
|
Included in #753, closing this PR |
Fixes issue with redundant variables: "PPA revenue gross" and "PPA revenue net" were in fact using the same calculations now that we transitioned electricity purchases to an O&M cost regardless of payment method. Remove PPA revenue gross, since it wasn't used in any downstream calculations.
Pairs with SAM PR: NatLabRockies/SAM#919