Fix SSC 720#733
Merged
Merged
Conversation
… values to dc_hourly_peak once, instead of at each new hour
Collaborator
Author
|
build-on-mac push is another one of the intermittent failures that might be related to #719. Since build-on-mac pull request passed, I'm consider that a pass of the unit tests. |
cpaulgilman
requested changes
Jan 28, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good.
Per #720 conversation, change label of Year 1 hourly variable "Demand charge with system" and "Demand charge without system" to "Incremental demand charge with [/without] system." This variable is helpful for understanding LCOS calculation and price signal dispatch.
cpaulgilman
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #720