Address issue #539 - inverter loss in buy all/ sell all moved to highest tier that has not reached upper bound#673
Merged
Conversation
…est tier that has not reached upper bound
cpaulgilman
approved these changes
Nov 28, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
I confirm that the difference between w system usage and w/o system usage is assigned to the highest tier, and that the energy charge reflects that difference.
Collaborator
Author
|
The one failing test runs fine on Windows Retesting on Travis running single test ::testing::GTEST_FLAG(filter) = "CMPvsamv1BatteryIntegration_cmod_pvsamv1.ResidentialDCBatteryModelPriceSignalDispatch"; batt_DOD_cycle_average output difference - separate issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.