Update pvsamv1 to assume anti-reflective glass#662
Merged
Conversation
added 4 commits
November 16, 2021 13:59
…glass and updated associated tests
…ferences due to pvyield
sjanzou
approved these changes
Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates pvsamv1 to assume anti-reflective glass by default, and updates the associated tests. Annual energy increases due to this change. This is consistent with the assumptions we make in pvwattsv7 and pvwattsv8. The SAM test script needs to be re-run for these changes, but at the moment I'm getting geothermal equations errors. Closes #323