PVWatts5_1ts shading#462
Merged
Merged
Conversation
Author
dguittet
requested changes
Oct 22, 2020
dguittet
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution! This is good to merge. The only thing that's missing is adding this to our unit test for pvwattsv5_1ts here: https://github.com/NREL/ssc/blob/0e23a2b37fb2a7e02027664baa12f398369fca3f/test/ssc_test/cmod_pvwattsv5_test.cpp#L130
Could you please add this variable to the inputs and just check that the changes to the test results are as you expect?
nmerket
commented
Oct 22, 2020
added 3 commits
October 22, 2020 16:32
(cherry picked from commit 0772c6f8a1836321d1f8819bea8f22cb9b498358)
dguittet
approved these changes
Oct 26, 2020
dguittet
left a comment
Collaborator
There was a problem hiding this comment.
I'll merge this once Travis is done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
shading_percentparameter to the PVWatts5_1ts model.