Skip to content

IPH outputs during startup and on modes#1329

Merged
tyneises merged 7 commits into
patchfrom
iph-control-bug-fixes
May 28, 2025
Merged

IPH outputs during startup and on modes#1329
tyneises merged 7 commits into
patchfrom
iph-control-bug-fixes

Conversation

@tyneises

Copy link
Copy Markdown
Collaborator

During hourly timesteps where the trough or fresnel solar field was in startup for part of the timestep and on for part of the timestep, the hourly output for solar field thermal power mistakenly included weighted values from startup mode. See this thread on the SAM support forum for more details https://sam.nrel.gov/forum/forum-general/3841-differences-fileld-fraction-of-focused-sca-and-flield-optical-focus-fraction.html#14072

@coveralls

coveralls commented May 27, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15282998575

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1378 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.01%) to 54.75%

Files with Coverage Reduction New Missed Lines %
ssc/ssc/cmod_fresnel_physical.cpp 62 88.72%
ssc/ssc/cmod_trough_physical.cpp 139 75.96%
ssc/ssc/cmod_trough_physical_iph.cpp 142 72.54%
ssc/ssc/cmod_fresnel_physical_iph.cpp 249 0.0%
ssc/tcs/csp_solver_fresnel_collector_receiver.cpp 262 83.19%
ssc/tcs/csp_solver_trough_collector_receiver.cpp 524 74.54%
Totals Coverage Status
Change from base Build 15218860011: 0.01%
Covered Lines: 64390
Relevant Lines: 117608

💛 - Coveralls

@tyneises tyneises merged commit e3949fc into patch May 28, 2025
10 checks passed
@tyneises tyneises deleted the iph-control-bug-fixes branch June 2, 2025 14:31
@tyneises tyneises added this to the SAM 2025 release patch 1 milestone Jun 4, 2025
@tyneises tyneises requested a review from cpaulgilman June 4, 2025 20:06
@cpaulgilman cpaulgilman added csp concentrating solar power added to release notes labels Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes csp concentrating solar power

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants