Marine cost updates#1305
Merged
Merged
Conversation
5 tasks
janinefreeman
approved these changes
Mar 28, 2025
Pull Request Test Coverage Report for Build 14178232998Details
💛 - Coveralls |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Update cost curves
-Add placeholder cost curve for RM2 (currently has Generic Tidal cost curves)
-Closes #1279
-Fix wavefile reading for jpd file generation (length check, modulo basis issues with 2920 vs 8760)
-Modifies changes made in #1275 to better represent variable dependencies (tidal_power_curve is always required so should be the memory allocation variable)