Skip to content

Enforce non-negative batt to load numbers#1294

Merged
brtietz merged 1 commit into
developfrom
sam_1914_correct_negative_batt_to_load
Mar 12, 2025
Merged

Enforce non-negative batt to load numbers#1294
brtietz merged 1 commit into
developfrom
sam_1914_correct_negative_batt_to_load

Conversation

@brtietz

@brtietz brtietz commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

Fixes NatLabRockies/SAM#1914 - see issue for test file.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13775817828

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.116%

Totals Coverage Status
Change from base Build 13746205635: 0.0%
Covered Lines: 65135
Relevant Lines: 132614

💛 - Coveralls

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results look good in SAM. Thanks for fixing.

@brtietz brtietz merged commit 91e13d4 into develop Mar 12, 2025
@brtietz brtietz deleted the sam_1914_correct_negative_batt_to_load branch April 18, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Negative "battery to load" numbers when losses are present.

3 participants