Incorperate inverter losses into grid limits code#1277
Merged
Conversation
cpaulgilman
approved these changes
Feb 21, 2025
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous grid limits code did not properly account for inverter night time losses, this code corrects that issue.
Note that there are still some issues with power to grid below 10% battery SOC. Those might be better solved as a part of #1202
Fixes NatLabRockies/SAM#1982