Create functions for battery parameters that were accessed in the code.#1251
Merged
Conversation
…e. This prevents copying the entire params object multiple times each step. Improves battery runtimes, especially for PV smoothing
dguittet
approved these changes
Dec 2, 2024
sjanzou
approved these changes
Dec 3, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and thanks for adding access to only the necessary parameters - makes debugging easier for our future selves!
Any stats on the reduced memory or execution time?
Collaborator
Author
Looks like this shaved 56 seconds off of the PVSmoothing tests on Ubuntu. Develop:
This branch:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents copying the entire params object multiple times each step. Improves battery runtimes, especially for PV smoothing.
Happy to add const pointer changes to this PR as well if we want to do that too.