Refactor adjust losses to use vartable instead of cmod #1234
Merged
Conversation
…ore accesible to the battery code
cpaulgilman
approved these changes
Oct 31, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks ok to me based on some basic tests in UI with parametrics and Loss Ajdustment widget.
dguittet
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor adjust losses to make them more accessible to the battery. We expect no changes, but need to test to make sure this approach is threadsafe. My initial runs with parameterics looked reasonable.