Add capacity factor input to tidal turbine ssc_eqn#1218
Merged
Conversation
9 tasks
cpaulgilman
reviewed
Oct 8, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
@mjprilliman Variable naming is confusing to me because I expect target_cf to be an input and capacity_factor to be an output, but here target_cf is being set to capacity_factor.
cpaulgilman
approved these changes
Oct 8, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for changing the variable names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Use target capacity factor to calculate power curve for tidal turbine design feature
-Input was previously hardcoded
-See NatLabRockies/SAM#1807