Skip to content

Bifacial snow model correction#1214

Merged
mjprilliman merged 5 commits into
developfrom
bifi-snow-correction
Oct 8, 2024
Merged

Bifacial snow model correction#1214
mjprilliman merged 5 commits into
developfrom
bifi-snow-correction

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Fixes (NatLabRockies/SAM#1739)
-Add rear POA to heat transfer balance equation for determining snow sliding
-scale snow cover losses by poa_front / total poa, as snow is not shading rear of module
-Add test coverage for snow/bifacial interactions
-Confirm that snow model calculates no snow coverage for vertical arrays.

@mjprilliman mjprilliman added the pv photovoltaic, pvsam, pvwatts label Oct 4, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Oct 4, 2024
@mjprilliman mjprilliman self-assigned this Oct 4, 2024
@mjprilliman mjprilliman changed the title Bifi snow correction Bifacial snow model correction Oct 4, 2024

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for irradiance and power production calculations. I wonder about the "DC power loss due to snow" output. In the released version, this was a useful indiciator of what % of the panel was covered:

image

now it's a bit noisier with the bifacial calculations:

image

Is it worth adding an additional output (maybe just to detailed PV) that matches the old output such that it's easier to see what the snow model is doing?

Comment thread ssc/cmod_pvsamv1.cpp Outdated
@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Code looks good for irradiance and power production calculations. I wonder about the "DC power loss due to snow" output. In the released version, this was a useful indiciator of what % of the panel was covered:

image

now it's a bit noisier with the bifacial calculations:

image

Is it worth adding an additional output (maybe just to detailed PV) that matches the old output such that it's easier to see what the snow model is doing?

I think in pvsamv1 Subarray X Snow cover (0-1) is sufficient for that visual checking. Agreed on PVWatts, I can look at adding a similar output.

@mjprilliman mjprilliman requested a review from brtietz October 7, 2024 22:42

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the output and cleaning up the unused variables!

@janinefreeman janinefreeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

Comment thread ssc/cmod_pvwattsv7.cpp Outdated
{ SSC_OUTPUT, SSC_ARRAY, "tpoa", "Transmitted plane of array irradiance", "W/m2", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "tcell", "Module temperature", "C", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "dcsnowderate", "DC power loss due to snow", "%", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "snow_cover", "Snow coverage", "0..1", "", "Time Series", "*", "", "" },

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description might be clearer as "Fraction of row covered by snow"

Comment thread ssc/cmod_pvwattsv8.cpp Outdated
{ SSC_OUTPUT, SSC_ARRAY, "tpoa", "Transmitted plane of array irradiance", "W/m2", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "tcell", "Module temperature", "C", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "dcsnowderate", "DC power loss due to snow", "%", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "snow_cover", "Snow coverage", "0..1", "", "Time Series", "*", "", "" },

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as pvwattsv7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes pv photovoltaic, pvsam, pvwatts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAM snow losses overestimate losses for bifacial systems

4 participants