Sam 1803 basis corrections#1193
Conversation
…f allowable costs
sjanzou
left a comment
There was a problem hiding this comment.
The cmod changes look fine but why are the CMakeLists and ci.yml files changing?
Also, should we update the failing test inputs and outputs for patch 2 merging?
…asis_corrections
I had some commits from patch on this branch. Now that #1188 is merged these are no longer shown as changes.
This PR is targeted at develop, the patch branch should be good for patch 2. I'd rather wait until we have Michele's feedback to update those tests so I don't have to do it twice. @cpaulgilman Pending your review, this is ready for updating send to excel with equations. |
* "Total depreciation basis prior to allocation" to "Depreciation basis prior to allocation" * "Total ITC basis prior to qualification" to "ITC basis prior to qualification" * "Financing cost" to "Total financing cost" to help distinguish from "Other financing cost" input and because it is the sum of several financing costs.
sjanzou
left a comment
There was a problem hiding this comment.
Label changes and functionality looks good!
Goes with NatLabRockies/SAM#1860
Update the depreciation and ITC basis calculations based on updated understanding from 1803
Next steps:
While the milestone says release (as that is when the code will be released), it'd be great to get steps 1-3 done before the patch.
There are basically two equations used:
a. Single owner, community solar, merchant plant, and host developer all have the same relevant inputs and include pre-financing, construction financing, and other financing costs
b. Sale leaseback, leveraged partnership flip, and equity partnership flip add the equity closing and developer fees to these three
Cash loan, third party, and (reassuringly) sale leaseback don't change in this PR. Currently, their ssc tests are expected to pass, whereas the other 6 financial models tests are expected to fail.
Some portions of this PR duplicate commits from #1188. That is waiting on #1190 to be resolved.